]> xenbits.xensource.com Git - people/aperard/linux.git/commitdiff
Revert "interconnect: Fix locking for runpm vs reclaim"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 4 Mar 2024 13:10:12 +0000 (14:10 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 6 Mar 2024 14:45:19 +0000 (14:45 +0000)
This reverts commit ee42bfc791aa3cd78e29046f26a09d189beb3efb which is
commit af42269c3523492d71ebbe11fefae2653e9cdc78 upstream.

It is reported to cause boot crashes in Android systems, so revert it
from the stable trees for now.

Cc: Rob Clark <robdclark@chromium.org>
Cc: Georgi Djakov <djakov@kernel.org>
Cc: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/interconnect/core.c

index 1d9494f64a21574db4b174a955fc26819f12b2fd..87f380e0e982e43b28d642b378c1ac46e58a1b2a 100644 (file)
@@ -29,7 +29,6 @@ static LIST_HEAD(icc_providers);
 static int providers_count;
 static bool synced_state;
 static DEFINE_MUTEX(icc_lock);
-static DEFINE_MUTEX(icc_bw_lock);
 static struct dentry *icc_debugfs_dir;
 
 static void icc_summary_show_one(struct seq_file *s, struct icc_node *n)
@@ -636,7 +635,7 @@ int icc_set_bw(struct icc_path *path, u32 avg_bw, u32 peak_bw)
        if (WARN_ON(IS_ERR(path) || !path->num_nodes))
                return -EINVAL;
 
-       mutex_lock(&icc_bw_lock);
+       mutex_lock(&icc_lock);
 
        old_avg = path->reqs[0].avg_bw;
        old_peak = path->reqs[0].peak_bw;
@@ -668,7 +667,7 @@ int icc_set_bw(struct icc_path *path, u32 avg_bw, u32 peak_bw)
                apply_constraints(path);
        }
 
-       mutex_unlock(&icc_bw_lock);
+       mutex_unlock(&icc_lock);
 
        trace_icc_set_bw_end(path, ret);
 
@@ -971,7 +970,6 @@ void icc_node_add(struct icc_node *node, struct icc_provider *provider)
                return;
 
        mutex_lock(&icc_lock);
-       mutex_lock(&icc_bw_lock);
 
        node->provider = provider;
        list_add_tail(&node->node_list, &provider->nodes);
@@ -997,7 +995,6 @@ void icc_node_add(struct icc_node *node, struct icc_provider *provider)
        node->avg_bw = 0;
        node->peak_bw = 0;
 
-       mutex_unlock(&icc_bw_lock);
        mutex_unlock(&icc_lock);
 }
 EXPORT_SYMBOL_GPL(icc_node_add);
@@ -1137,7 +1134,6 @@ void icc_sync_state(struct device *dev)
                return;
 
        mutex_lock(&icc_lock);
-       mutex_lock(&icc_bw_lock);
        synced_state = true;
        list_for_each_entry(p, &icc_providers, provider_list) {
                dev_dbg(p->dev, "interconnect provider is in synced state\n");