]> xenbits.xensource.com Git - people/sstabellini/xen-unstable.git/.git/commitdiff
AMD/IOMMU: honour IR setting while pre-filling DTEs
authorIgor Druzhinin <igor.druzhinin@citrix.com>
Tue, 26 Nov 2019 17:08:19 +0000 (17:08 +0000)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Wed, 27 Nov 2019 11:28:24 +0000 (11:28 +0000)
IV bit shouldn't be set in DTE if interrupt remapping is not
enabled. It's a regression in behavior of "iommu=no-intremap"
option which otherwise would keep interrupt requests untranslated
for all of the devices in the system regardless of wether it's
described as valid in IVRS or not.

Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Release-acked-by: Juergen Gross <jgross@suse.com>
xen/drivers/passthrough/amd/iommu_init.c

index 16e84d43d482dcfad24f815ddb8c4f84bb0e9d24..2b81e38f1632d0ef16125e18dd76aca29c7acba2 100644 (file)
@@ -1279,7 +1279,7 @@ static int __init amd_iommu_setup_device_table(
         for ( bdf = 0, size /= sizeof(*dt); bdf < size; ++bdf )
             dt[bdf] = (struct amd_iommu_dte){
                           .v = true,
-                          .iv = true,
+                          .iv = iommu_intremap,
                       };
     }