vbd: Fixed broken rollback after open_vdi failure.

Signed-off-by: Daniel Stodden <daniel.stodden@citrix.com>

diff --git a/drivers/tapdisk-vbd.c b/drivers/tapdisk-vbd.c
index 18d098bd29ce8cf1ed86f9d94e510b03a83b5548..05a6e546f8ca0edda5d72a70677dc8678746f65f 100644 (file)
--- a/drivers/tapdisk-vbd.c
+++ b/drivers/tapdisk-vbd.c
@@ -422,7 +422,6 @@ fail:
 int
 tapdisk_vbd_open_vdi(td_vbd_t *vbd, const char *name, td_flag_t flags, int prt_devnum)
 {
-       td_image_t *image = NULL;
        char *tmp = vbd->name;
        int err;
 
@@ -490,10 +489,8 @@ fail:
                vbd->name = tmp;
        }
 
-       if (image) {
-               list_del_init(&vbd->images);
-               tapdisk_image_close(image);
-       }
+       if (!list_empty(&vbd->images))
+               tapdisk_image_close_chain(&vbd->images);
 
        vbd->flags = 0;