]> xenbits.xensource.com Git - qemu-xen.git/commitdiff
pci-bridge/xio3130_upstream: Fix error handling
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Fri, 18 Feb 2022 10:23:02 +0000 (10:23 +0000)
committerMichael S. Tsirkin <mst@redhat.com>
Sun, 6 Mar 2022 10:08:23 +0000 (05:08 -0500)
Goto label is incorrect so msi cleanup would not occur if there is
an error in the ssvid initialization.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Message-Id: <20220218102303.7061-1-Jonathan.Cameron@huawei.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/pci-bridge/xio3130_upstream.c

index 5cd3af4fbc09c9e15c6af0afc0d991932589c531..5ff46ef0504747c212f2a6ac11a46062883476ba 100644 (file)
@@ -75,7 +75,7 @@ static void xio3130_upstream_realize(PCIDevice *d, Error **errp)
                                XIO3130_SSVID_SVID, XIO3130_SSVID_SSID,
                                errp);
     if (rc < 0) {
-        goto err_bridge;
+        goto err_msi;
     }
 
     rc = pcie_cap_init(d, XIO3130_EXP_OFFSET, PCI_EXP_TYPE_UPSTREAM,