bisection: Do not get bisection start points from broken flights

cs-bisection-step ignores any flight with broken steps, on the grounds
that the results in such a flight maybe unreliable.

Therefore, if a main flight has both broken steps and regressions, it
is wrong to take its mro as the new basis mro for bisections.  In the
worst case a newly failing job will be determined to be unbisectable
(since the only relevant failure is in a broken flight), have the
stamp file created, and then never be properly bisected.

So: in sg-report-flight, report `broken-step' for each broken step (in
the top-level flight we are reporting - broken jobs in flights we are
referring to to justify heisenbugs are OK); and, in cr-daily-branch,
do not install the new mro if such indications are present.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

diff --git a/cr-daily-branch b/cr-daily-branch
index 90eb49965e110eb65b2419da642ed6687cda22f8..d00ecbb4809cdab814f672cb3570eb78ad63d8df 100755 (executable)
--- a/cr-daily-branch
+++ b/cr-daily-branch
@@ -312,7 +312,7 @@ if test -f $branch.force; then push=$OSSTEST_PUSH; fi
 if grep -xF $NEW_REVISION $branch.force-rev; then push=$OSSTEST_PUSH; fi
 if test -f $branch.block; then push=false; fi
 
-if test -e $mrof && test -e $tree_bisect; then
+if test -e $mrof && test -e $tree_bisect && ! grep '^broken' $mrof; then
        with-lock-ex -w $tree_bisect/$mrof.lock bash -xec "
                rm -f $tree_bisect/$mrof.in.new
                cp $mrof $tree_bisect/$mrof.in.new

diff --git a/sg-report-flight b/sg-report-flight
index c8d88e81885c31c7add31c9222a226ad1979b032..062107ade4acb83a0f154dc63e82867c0ecbe14e 100755 (executable)
--- a/sg-report-flight
+++ b/sg-report-flight
@@ -647,6 +647,11 @@ END
             $failv->{Blocker}= '';
            next;
        }
+
+       if ($st eq 'broken' && !$heisen_why) {
+           print MRO "broken-step $s->{job} $s->{testid}\n";
+       }
+
         if (!($st eq 'fail' or $st eq 'broken')) {
             print MRO "broken $j->{job} $s->{testid} $st\n";
             print DEBUG " not a fail, unjustifiable\n";