]> xenbits.xensource.com Git - qemu-upstream-unstable.git/commitdiff
xen/pt: mark all PCIe capability bits read-only
authorJan Beulich <jbeulich@suse.com>
Tue, 2 Jun 2015 15:43:08 +0000 (15:43 +0000)
committerStefano Stabellini <stefano.stabellini@eu.citrix.com>
Tue, 9 Jun 2015 10:28:54 +0000 (10:28 +0000)
xen_pt_emu_reg_pcie[]'s PCI_EXP_DEVCAP needs to cover all bits as read-
only to avoid unintended write-back (just a precaution, the field ought
to be read-only in hardware).

This is a preparatory patch for XSA-131.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
hw/xen/xen_pt_config_init.c

index 1a18dbb94d8f786dca487897f950452d58071169..dd14f909f6132793df1d6d07ad55ebb021bebb45 100644 (file)
@@ -873,7 +873,7 @@ static XenPTRegInfo xen_pt_emu_reg_pcie[] = {
         .offset     = PCI_EXP_DEVCAP,
         .size       = 4,
         .init_val   = 0x00000000,
-        .ro_mask    = 0x1FFCFFFF,
+        .ro_mask    = 0xFFFFFFFF,
         .emu_mask   = 0x10000000,
         .init       = xen_pt_common_reg_init,
         .u.dw.read  = xen_pt_long_reg_read,