]> xenbits.xensource.com Git - people/pauldu/qemu.git/commitdiff
hw/block: m25p80: Don't write to flash if write is disabled
authorBin Meng <bin.meng@windriver.com>
Wed, 23 Dec 2020 02:00:24 +0000 (10:00 +0800)
committerAlistair Francis <alistair.francis@wdc.com>
Sat, 16 Jan 2021 18:57:21 +0000 (10:57 -0800)
When write is disabled, the write to flash should be avoided
in flash_write8().

Fixes: 82a2499011a7 ("m25p80: Initial implementation of SPI flash device")
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
Message-id: 1608688825-81519-1-git-send-email-bmeng.cn@gmail.com
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
hw/block/m25p80.c

index 1b3f2405a11979e2cd7ccc968a74a9deee62a6a3..63278cbda5fd3fefd407557840de4fef6f74f54c 100644 (file)
@@ -601,6 +601,7 @@ void flash_write8(Flash *s, uint32_t addr, uint8_t data)
 
     if (!s->write_enable) {
         qemu_log_mask(LOG_GUEST_ERROR, "M25P80: write with write protect!\n");
+        return;
     }
 
     if ((prev ^ data) & data) {