]> xenbits.xensource.com Git - xen.git/commitdiff
tools/gdbsx: fix build with clang 3.8
authorWei Liu <wei.liu2@citrix.com>
Mon, 23 Jul 2018 10:26:48 +0000 (11:26 +0100)
committerWei Liu <wei.liu2@citrix.com>
Tue, 24 Jul 2018 08:16:01 +0000 (09:16 +0100)
Currently building gdbsx with clang 3.8 gives the following errors:

xg_main.c:783:17: error: 'aligned' attribute ignored when parsing type [-Werror,-Wignored-attributes]
    iop->uva = (uint64_aligned_t)((unsigned long)tobuf);
                ^~~~~~~~~~~~~~~~
/builds/liuw/xen/tools/debugger/gdbsx/xg/../../../../tools/include/xen/arch-x86/xen-x86_32.h:105:50: note: expanded from macro 'uint64_aligned_t'
                                                 ^~~~~~~~~~
xg_main.c:816:17: error: 'aligned' attribute ignored when parsing type [-Werror,-Wignored-attributes]
    iop->uva = (uint64_aligned_t)((unsigned long)frombuf);
                ^~~~~~~~~~~~~~~~
/builds/liuw/xen/tools/debugger/gdbsx/xg/../../../../tools/include/xen/arch-x86/xen-x86_32.h:105:50: note: expanded from macro 'uint64_aligned_t'

According to https://bugs.llvm.org/show_bug.cgi?id=11071, this issue has
been fixed in clang. But we're not going to get that in 3.8.

Explicitly disable that warning to fix the build.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
tools/debugger/gdbsx/Rules.mk

index 6e38f2df995c3ed2e3bb77dc740a43989e114e7c..920f1c87fb7efc9258d33e7ecaf00d994ed6f3ea 100644 (file)
@@ -2,3 +2,5 @@ include $(XEN_ROOT)/tools/Rules.mk
 
 CFLAGS   += -Werror -Wmissing-prototypes 
 # (gcc 4.3x and later)   -Wconversion -Wno-sign-conversion
+
+CFLAGS-$(clang) += -Wno-ignored-attributes