]> xenbits.xensource.com Git - libvirt.git/commitdiff
virLXCProcessSetupNamespaceName: Fix potential uninitialized free of 'path'
authorPeter Krempa <pkrempa@redhat.com>
Thu, 5 Mar 2020 08:25:35 +0000 (09:25 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 5 Mar 2020 15:21:47 +0000 (16:21 +0100)
'path' could be accessed uninitialized. Fix it by using g_autofree which
also mandates initialization.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/lxc/lxc_process.c

index 0277ba8b62af07c927040d4d975f69533d114330..cd0026f78f06c51481ea5ddcb982ae7d98ec32d5 100644 (file)
@@ -409,7 +409,7 @@ static int virLXCProcessSetupNamespaceName(virLXCDriverPtr driver,
     int fd = -1;
     virDomainObjPtr vm;
     virLXCDomainObjPrivatePtr priv;
-    char *path;
+    g_autofree char *path = NULL;
 
     vm = virDomainObjListFindByName(driver->domains, name);
     if (!vm) {
@@ -436,7 +436,6 @@ static int virLXCProcessSetupNamespaceName(virLXCDriverPtr driver,
     }
 
  cleanup:
-    VIR_FREE(path);
     virDomainObjEndAPI(&vm);
     return fd;
 }