]> xenbits.xensource.com Git - libvirt.git/commitdiff
libxl: call EndJob in error case
authorJim Fehlig <jfehlig@suse.com>
Fri, 16 Mar 2018 21:22:45 +0000 (15:22 -0600)
committerJim Fehlig <jfehlig@suse.com>
Wed, 21 Mar 2018 18:40:21 +0000 (12:40 -0600)
If starting the domain fails in libxlDomainCreateXML, we mistakenly
jumped to cleanup without calling libxlDomainObjEndJob. Remove the
jump to 'cleanup'.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>
src/libxl/libxl_driver.c

index ac61fb32219a3afd4bdc7b4b5c8a39d47162107f..3ebeacca8180cb35290ea1b492d8073023123ecd 100644 (file)
@@ -1066,7 +1066,6 @@ libxlDomainCreateXML(virConnectPtr conn, const char *xml,
         if (!vm->persistent) {
             virDomainObjListRemove(driver->domains, vm);
             virObjectLock(vm);
-            goto cleanup;
         }
         goto endjob;
     }