]> xenbits.xensource.com Git - libvirt.git/commitdiff
Revert "logical: Only raw volumes are supported"
authorRoman Bogorodskiy <bogorodskiy@gmail.com>
Sun, 27 Mar 2016 14:59:22 +0000 (10:59 -0400)
committerJohn Ferlan <jferlan@redhat.com>
Sun, 27 Mar 2016 15:09:53 +0000 (11:09 -0400)
This reverts commit 6682d6219d4595b51f06867e0c30e7efd745f682.

The "if (vol->target.format != VIR_STORAGE_FILE_RAW)" check in the
createVol backend. This check is bogus because virStorageVolDefParseXML()
in conf/storage_conf.c sets target.format only if volOptions in
virStoragePoolTypeInfo has formatFromString set, and that's not the
case the logical backend.

So the check always fails and breaks volume creation.

src/storage/storage_backend_logical.c

index 39e8b80ed08da216210cacc25fc1c5698c24bbe8..90a194ebc44c75f84bfa03e97fa1b96554e6f9cf 100644 (file)
@@ -912,12 +912,6 @@ virStorageBackendLogicalCreateVol(virConnectPtr conn,
     struct stat sb;
     bool created = false;
 
-    if (vol->target.format != VIR_STORAGE_FILE_RAW) {
-        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
-                       _("only RAW volumes are supported by this storage pool"));
-        return -1;
-    }
-
     if (vol->target.encryption != NULL) {
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                        "%s", _("storage pool does not support encrypted "