]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemuProcessQMPConnectMonitor: Connect to probing monitor with 'retry' set to false
authorPeter Krempa <pkrempa@redhat.com>
Tue, 2 Aug 2022 12:26:41 +0000 (14:26 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 3 Aug 2022 12:26:56 +0000 (14:26 +0200)
In 'qemuProcessQMPLaunch' qemu is very specifically launched using it's
internal '-daemonize' flag (see comment in the function) to ensure that
the monitor socket is ready and opened prior to attempting the monitor
connection.

This means we don't have to retry the connection to the monitor in
qemuMonitorOpen as the socket will be already there.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Jonathon Jongsma <jjongsma@redhat.com>
src/qemu/qemu_process.c

index 1cd55fe989a92746cc5e0305f08f94102bb88434..c51d704af802ea86b633494c574fd0f2b39ed664 100644 (file)
@@ -9493,7 +9493,7 @@ qemuProcessQMPConnectMonitor(qemuProcessQMP *proc)
 
     proc->vm->pid = proc->pid;
 
-    if (!(proc->mon = qemuMonitorOpen(proc->vm, &monConfig, true,
+    if (!(proc->mon = qemuMonitorOpen(proc->vm, &monConfig, false,
                                       virEventThreadGetContext(proc->eventThread),
                                       &callbacks)))
         return -1;