]> xenbits.xensource.com Git - libvirt.git/commitdiff
util: Clear up some perf error messages
authorJohn Ferlan <jferlan@redhat.com>
Fri, 7 Oct 2016 12:14:37 +0000 (08:14 -0400)
committerJohn Ferlan <jferlan@redhat.com>
Fri, 7 Oct 2016 17:27:21 +0000 (13:27 -0400)
Make it clearer that the perf event is based/for the host cpu and
use the virPerfEventTypeToString to convert the type to a string

src/util/virperf.c

index a65a4bfefa5759951489b323ef94c678272e32a8..638743098b194fb3631b51e84ed05e8a4d4ae633 100644 (file)
@@ -175,7 +175,7 @@ virPerfEventEnable(virPerfPtr perf,
                                        type == VIR_PERF_EVENT_MBMT ||
                                        type == VIR_PERF_EVENT_MBML)) {
         virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED,
-                       _("unable to enable perf event for %s"),
+                       _("unable to enable host cpu perf event for %s"),
                        virPerfEventTypeToString(event->type));
         return -1;
     }
@@ -205,14 +205,14 @@ virPerfEventEnable(virPerfPtr perf,
     event->fd = syscall(__NR_perf_event_open, &attr, pid, -1, -1, 0);
     if (event->fd < 0) {
         virReportSystemError(errno,
-                             _("Unable to open perf event for %s"),
+                             _("unable to open host cpu perf event for %s"),
                              virPerfEventTypeToString(event->type));
         goto error;
     }
 
     if (ioctl(event->fd, PERF_EVENT_IOC_ENABLE) < 0) {
         virReportSystemError(errno,
-                             _("Unable to enable perf event for %s"),
+                             _("unable to enable host cpu perf event for %s"),
                              virPerfEventTypeToString(event->type));
         goto error;
     }
@@ -236,8 +236,8 @@ virPerfEventDisable(virPerfPtr perf,
 
     if (ioctl(event->fd, PERF_EVENT_IOC_DISABLE) < 0) {
         virReportSystemError(errno,
-                             _("Unable to disable perf event type=%d"),
-                             event->type);
+                             _("unable to disable host cpu perf event for %s"),
+                             virPerfEventTypeToString(event->type));
         return -1;
     }