]> xenbits.xensource.com Git - libvirt.git/commitdiff
conf: check address type for USB hostdevs
authorJán Tomko <jtomko@redhat.com>
Wed, 23 Aug 2017 14:32:28 +0000 (16:32 +0200)
committerJán Tomko <jtomko@redhat.com>
Thu, 24 Aug 2017 07:28:53 +0000 (09:28 +0200)
https://bugzilla.redhat.com/show_bug.cgi?id=1225339

src/conf/domain_conf.c

index 33470ffcb09b115658df8b3445140a6bd30703ba..478feb92d88c28f3d2a7ad2e61badcc11651b736 100644 (file)
@@ -5287,6 +5287,13 @@ virDomainHostdevDefValidate(const virDomainHostdevDef *hostdev)
             }
             break;
         case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB:
+            if (hostdev->info->type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE &&
+                hostdev->info->type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_USB) {
+                virReportError(VIR_ERR_XML_ERROR, "%s",
+                               _("USB host device must use 'usb' address type"));
+                return -1;
+            }
+            break;
         case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV:
         case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST:
             break;