conf: numa: Format <numatune> XML only if necessary

Do a content-aware check if formatting of the <numatune> element is
necessary. Later on the def->numa structure will be always present so we
cannot decide only on the basis whether it's allocated.

diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c
index d86ac99a677eb25a6bc21f0db7b00b8fe9ec28e7..9b48fb87eaa6826bc312ce78a7813868b7d7e641 100644 (file)
--- a/src/conf/numa_conf.c
+++ b/src/conf/numa_conf.c
@@ -278,11 +278,22 @@ virDomainNumatuneFormatXML(virBufferPtr buf,
 {
     const char *tmp = NULL;
     char *nodeset = NULL;
+    bool nodesetSpecified = false;
     size_t i = 0;
 
     if (!numatune)
         return 0;
 
+    for (i = 0; i < numatune->nmem_nodes; i++) {
+        if (numatune->mem_nodes[i].nodeset) {
+            nodesetSpecified = true;
+            break;
+        }
+    }
+
+    if (!nodesetSpecified && !numatune->memory.specified)
+        return 0;
+
     virBufferAddLit(buf, "<numatune>\n");
     virBufferAdjustIndent(buf, 2);