]> xenbits.xensource.com Git - libvirt.git/commitdiff
virHostdevGetPCIHostDeviceList: Use VIR_AUTOPTR for virPCIDevice
authorMichal Privoznik <mprivozn@redhat.com>
Sat, 15 Jun 2019 06:28:05 +0000 (08:28 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Thu, 20 Jun 2019 08:29:54 +0000 (10:29 +0200)
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/util/virhostdev.c

index 9c63d0aebd5c159a9c70d4cf340fd7516dbfeebc..5935d926aac0f4d308fe55aeb6421667efbbc456 100644 (file)
@@ -227,7 +227,7 @@ virHostdevGetPCIHostDeviceList(virDomainHostdevDefPtr *hostdevs, int nhostdevs)
     for (i = 0; i < nhostdevs; i++) {
         virDomainHostdevDefPtr hostdev = hostdevs[i];
         virDomainHostdevSubsysPCIPtr pcisrc = &hostdev->source.subsys.u.pci;
-        virPCIDevicePtr pci;
+        VIR_AUTOPTR(virPCIDevice) pci = NULL;
 
         if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS)
             continue;
@@ -251,10 +251,10 @@ virHostdevGetPCIHostDeviceList(virDomainHostdevDefPtr *hostdevs, int nhostdevs)
             virPCIDeviceSetStubDriver(pci, VIR_PCI_STUB_DRIVER_KVM);
 
         if (virPCIDeviceListAdd(pcidevs, pci) < 0) {
-            virPCIDeviceFree(pci);
             virObjectUnref(pcidevs);
             return NULL;
         }
+        pci = NULL;
     }
 
     return pcidevs;