]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: Fix possible NULL deref in qemuDomainSaveImageStartVM
authorJohn Ferlan <jferlan@redhat.com>
Sun, 3 Nov 2019 12:35:25 +0000 (07:35 -0500)
committerJohn Ferlan <jferlan@redhat.com>
Wed, 6 Nov 2019 16:27:12 +0000 (11:27 -0500)
Commit 075523438 added a direct reference to @cookie even though
it may be NULL as shown by a comment a few lines previous - so add
the check here as well.

Found by Coverity

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
src/qemu/qemu_driver.c

index d17c18705b3ef8b4c38a3bec5df695decdb1edc8..56fcba8b2cb246f5476b9a58bf6f615b68c322cb 100644 (file)
@@ -6831,7 +6831,7 @@ qemuDomainSaveImageStartVM(virConnectPtr conn,
         qemuDomainFixupCPUs(vm, &cookie->cpu) < 0)
         goto cleanup;
 
-    if (!cookie->slirpHelper)
+    if (cookie && !cookie->slirpHelper)
         priv->disableSlirp = true;
 
     if (qemuProcessStart(conn, driver, vm, cookie ? cookie->cpu : NULL,