JobDB/Executive: Improve an internal `die' error

When this assertion fails, dump the troublesome harness revision and
requested host flags, too.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>

diff --git a/Osstest/JobDB/Executive.pm b/Osstest/JobDB/Executive.pm
index ba51bdfce3ca62175c99f1d387b0791091385f07..1ec947eb7c0f642749182e8be1df6fb4e0781eda 100644 (file)
--- a/Osstest/JobDB/Executive.pm
+++ b/Osstest/JobDB/Executive.pm
@@ -127,14 +127,17 @@ sub host_check_allocated ($$) { #method
     $ho->{SharedMaybeOthers}=
         $ho->{Shared} &&
         $ho->{Shared}{State} eq 'ready';
+    my $harness = get_harness_rev();
+    my @flags = get_hostflags($ho->{Ident});
     $ho->{SharedReady}=
        $ho->{SharedMaybeOthers} &&
-        !! (grep { $_." ".get_harness_rev() eq "share-".$ho->{Shared}{Type} }
-           get_hostflags($ho->{Ident}));
+        !! (grep { $_." ".$harness eq "share-".$ho->{Shared}{Type} }
+           @flags);
     $ho->{SharedOthers}=
         $ho->{Shared} ? $ho->{Shared}{Others} : 0;
     
-    die Dumper($ho)." ?" if $ho->{SharedOthers} && !$ho->{SharedReady};
+    die Dumper($ho, $harness, \@flags)." ?"
+       if $ho->{SharedOthers} && !$ho->{SharedReady};
 }
 
 sub jobdb_postfork ($) { #method