]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: Report pinning for all vCPUs in qemuDomainGetVcpuPinInfo
authorPeter Krempa <pkrempa@redhat.com>
Fri, 12 Feb 2016 13:57:41 +0000 (14:57 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 9 Mar 2016 09:09:16 +0000 (10:09 +0100)
The API documentation states that the function is returning pinning for
all vCPUs, so we can actually do so if the user passes a large enough
array.

src/conf/domain_conf.c

index 9bb12044c068a1419be6f9ec6ce61d670b48bc38..fc6758c227a57107d6791bad84619ffe441bd9fd 100644 (file)
@@ -1473,6 +1473,7 @@ virDomainDefGetVcpuPinInfoHelper(virDomainDefPtr def,
                                  int hostcpus,
                                  virBitmapPtr autoCpuset)
 {
+    int maxvcpus = virDomainDefGetVcpusMax(def);
     virBitmapPtr allcpumap = NULL;
     size_t i;
 
@@ -1484,17 +1485,10 @@ virDomainDefGetVcpuPinInfoHelper(virDomainDefPtr def,
 
     virBitmapSetAll(allcpumap);
 
-    /* Clamp to actual number of vcpus */
-    if (ncpumaps > virDomainDefGetVcpus(def))
-        ncpumaps = virDomainDefGetVcpus(def);
-
-    for (i = 0; i < ncpumaps; i++) {
+    for (i = 0; i < maxvcpus && i < ncpumaps; i++) {
         virDomainVcpuInfoPtr vcpu = virDomainDefGetVcpu(def, i);
         virBitmapPtr bitmap = NULL;
 
-        if (!vcpu->online)
-            continue;
-
         if (vcpu->cpumask)
             bitmap = vcpu->cpumask;
         else if (def->placement_mode == VIR_DOMAIN_CPU_PLACEMENT_MODE_AUTO &&
@@ -1509,7 +1503,7 @@ virDomainDefGetVcpuPinInfoHelper(virDomainDefPtr def,
     }
 
     virBitmapFree(allcpumap);
-    return ncpumaps;
+    return i;
 }