]> xenbits.xensource.com Git - people/andrewcoop/xen-test-framework.git/commitdiff
build: Drop unnecessary register clobbers
authorAndrew Cooper <andrew.cooper3@citrix.com>
Thu, 28 Sep 2017 09:43:04 +0000 (10:43 +0100)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Fri, 29 Sep 2017 14:34:49 +0000 (15:34 +0100)
The code in question is executing __HYPERVISOR_multicall which is 2-parameter
hypercall, which means that args 3-6 are preserved (as opposed to the
arguments in the multicall_entry_t list, which are clobbered).

GCC 4.4 in CentOS 6 can't cope with the ebp clobber.

Reported-by: Glenn Enright <glenn@rimuhosting.com>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
tests/xsa-213/main.c

index 34eac06124d199990f0be338754cd3d42525debe..6ecaf11c541c80d03ad053c1aa7217984b0fddd1 100644 (file)
@@ -95,12 +95,6 @@ static long multi_iret_call(multicall_entry_t *multi, size_t nr)
                     "b" (multi), "c" (nr)
 #else
                     "D" (multi), "S" (nr)
-#endif
-                  :
-#ifdef __i386__
-                  "edx", "esi", "edi", "ebp"
-#else
-                  "rdx", "r10", "r8", "r9"
 #endif
         );