]> xenbits.xensource.com Git - qemu-upstream-4.4-testing.git/commitdiff
console: Fix qemu_default_pixelformat() for 24 bpp
authorMarkus Armbruster <armbru@redhat.com>
Tue, 22 Nov 2011 11:56:10 +0000 (12:56 +0100)
committerStefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Tue, 6 Dec 2011 09:56:40 +0000 (09:56 +0000)
Falls through to 32 bpp.  Harmless, because the only difference is the
alpha component, and we're not using that.  Spotted by Coverity.

Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
console.c

index ce0429df8ca6b89595bf63099efdbc8d5ffffea7..223f8fd9a4563606c348c79c44887914a952e2c9 100644 (file)
--- a/console.c
+++ b/console.c
@@ -1688,6 +1688,7 @@ PixelFormat qemu_default_pixelformat(int bpp)
             pf.rbits = 8;
             pf.gbits = 8;
             pf.bbits = 8;
+            break;
         case 32:
             pf.rmask = 0x00FF0000;
             pf.gmask = 0x0000FF00;