]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
qemu: fix memory leak in opening log file
authorDaniel P. Berrange <berrange@redhat.com>
Thu, 3 Dec 2015 17:24:10 +0000 (17:24 +0000)
committerDaniel P. Berrange <berrange@redhat.com>
Mon, 7 Dec 2015 17:30:07 +0000 (17:30 +0000)
The qemuDomainLogContextNew method leaks the "logfile" path
on the non-virtlogd code path.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
src/qemu/qemu_domain.c

index a872598965997f7803941b1f3bbff7a22dc175ae..d60cf73a2915a8412ca4ab62b6123808b9eddc2e 100644 (file)
@@ -2360,13 +2360,15 @@ qemuDomainLogContextPtr qemuDomainLogContextNew(virQEMUDriverPtr driver,
         }
     }
 
+ cleanup:
     virObjectUnref(cfg);
+    VIR_FREE(logfile);
     return ctxt;
 
  error:
-    virObjectUnref(cfg);
     qemuDomainLogContextFree(ctxt);
-    return NULL;
+    ctxt = NULL;
+    goto cleanup;
 }