]> xenbits.xensource.com Git - people/tklengyel/xen.git/commitdiff
tools/firmware: Build firmware as -ffreestanding
authorAndrew Cooper <andrew.cooper3@citrix.com>
Thu, 25 Feb 2021 19:15:08 +0000 (19:15 +0000)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Mon, 1 Mar 2021 23:19:39 +0000 (23:19 +0000)
firmware should always have been -ffreestanding, as it doesn't execute in the
host environment.  -ffreestanding implies -fno-builtin, so replace the option.

inttypes.h isn't a freestanding header, but the 32bitbios_support.c only wants
the stdint.h types so switch to the more appropriate include.

This removes the build time dependency on a 32bit libc just to compile the
hvmloader and friends.

Update README and the TravisCI configuration.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Ian Jackson <iwj@xenproject.org>
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
.travis.yml
README
tools/firmware/Rules.mk
tools/firmware/hvmloader/32bitbios_support.c

index 15ca9e9047ff7c3ef43a10b07341b414d706f9c9..2362475f7a89d3c3facc34ddc05e56116ad59036 100644 (file)
@@ -58,7 +58,6 @@ addons:
             - acpica-tools
             - bin86
             - bcc
-            - libc6-dev-i386
             - libnl-3-dev
             - ocaml-nox
             - libfindlib-ocaml-dev
diff --git a/README b/README
index 6e15242ae19f58c50987a97f9ca17b3a6cf1af97..8c99c30986c1b7b780af40232b8f12dc7e178bc6 100644 (file)
--- a/README
+++ b/README
@@ -62,9 +62,6 @@ provided by your OS distributor:
     * GNU bison and GNU flex
     * GNU gettext
     * ACPI ASL compiler (iasl)
-    * Libc multiarch package (e.g. libc6-dev-i386 / glibc-devel.i686).
-      Required when building on a 64-bit platform to build
-      32-bit components which are enabled on a default build.
 
 In addition to the above there are a number of optional build
 prerequisites. Omitting these will cause the related features to be
index 26bbddccd410f58695301119edcffaa5bc61346b..dc372a86d89f440f11ab41d4f6d8d35a63a8d17f 100644 (file)
@@ -16,4 +16,4 @@ CFLAGS += -Werror
 $(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS))
 
 # Extra CFLAGS suitable for an embedded type of environment.
-CFLAGS += -fno-builtin -msoft-float
+CFLAGS += -ffreestanding -msoft-float
index 6f28fb6bdeb354bc83ad4b825eefe818b27e7ef3..cee3804888c447df7e952960312ad07023a07acc 100644 (file)
@@ -20,7 +20,7 @@
  * this program; If not, see <http://www.gnu.org/licenses/>.
  */
 
-#include <inttypes.h>
+#include <stdint.h>
 #include <xen/libelf/elfstructs.h>
 
 #include "util.h"