]> xenbits.xensource.com Git - libvirt.git/commitdiff
locking: Use bit shift for flag values not constant values.
authorJohn Ferlan <jferlan@redhat.com>
Fri, 4 Mar 2016 14:35:19 +0000 (09:35 -0500)
committerJohn Ferlan <jferlan@redhat.com>
Mon, 7 Mar 2016 20:48:19 +0000 (15:48 -0500)
So far it hasn't bitten us, but if the next value wasn't 4, then
the logic used to check flag bits would have issues.

src/locking/lock_driver_lockd.h

index baf346adaf6cb522a8cc5808c39e9b9ea0a10b05..6931fe742589a37ec7ec59fae86a4d58cada117d 100644 (file)
@@ -23,8 +23,8 @@
 # define __VIR_LOCK_DRIVER_LOCKD_H__
 
 enum virLockSpaceProtocolAcquireResourceFlags {
-        VIR_LOCK_SPACE_PROTOCOL_ACQUIRE_RESOURCE_SHARED = 1,
-        VIR_LOCK_SPACE_PROTOCOL_ACQUIRE_RESOURCE_AUTOCREATE = 2,
+        VIR_LOCK_SPACE_PROTOCOL_ACQUIRE_RESOURCE_SHARED = (1 << 0),
+        VIR_LOCK_SPACE_PROTOCOL_ACQUIRE_RESOURCE_AUTOCREATE = (1 << 1),
 };
 
 #endif /* __VIR_LOCK_DRIVER_LOCKD_H__ */