conf: use g_auto() for all virBuffers

Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>

diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c
index 99b69aebb5143a73fcf3e05e5d4db7cc8cc4c82b..6a48af1fcacb5f4562c271ba26bde9fdc07162cf 100644 (file)
--- a/src/conf/capabilities.c
+++ b/src/conf/capabilities.c
@@ -705,7 +705,7 @@ virCapabilitiesDomainDataLookupInternal(virCapsPtr caps,
 
     /* XXX check default_emulator, see how it uses this */
     if (!foundguest) {
-        virBuffer buf = VIR_BUFFER_INITIALIZER;
+        g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
         if (ostype)
             virBufferAsprintf(&buf, "ostype=%s ",
                               virDomainOSTypeToString(ostype));
@@ -725,7 +725,6 @@ virCapabilitiesDomainDataLookupInternal(virCapsPtr caps,
         virReportError(VIR_ERR_INVALID_ARG,
                        _("could not find capabilities for %s"),
                        virBufferCurrentContent(&buf));
-        virBufferFreeAndReset(&buf);
         return ret;
     }
 
@@ -901,7 +900,7 @@ virCapabilitiesFormatResctrlMonitor(virBufferPtr buf,
                                     virResctrlInfoMonPtr monitor)
 {
     size_t i = 0;
-    virBuffer childrenBuf = VIR_BUFFER_INIT_CHILD(buf);
+    g_auto(virBuffer) childrenBuf = VIR_BUFFER_INIT_CHILD(buf);
 
     /* monitor not supported, no capability */
     if (!monitor)
@@ -1335,7 +1334,7 @@ virCapabilitiesFormatStoragePoolXML(virCapsStoragePoolPtr *pools,
 char *
 virCapabilitiesFormatXML(virCapsPtr caps)
 {
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
 
     virBufferAddLit(&buf, "<capabilities>\n\n");
     virBufferAdjustIndent(&buf, 2);
@@ -1353,7 +1352,6 @@ virCapabilitiesFormatXML(virCapsPtr caps)
     return virBufferContentAndReset(&buf);
 
  error:
-    virBufferFreeAndReset(&buf);
     return NULL;
 }
 

diff --git a/src/conf/checkpoint_conf.c b/src/conf/checkpoint_conf.c
index 3405e8a3ccff9735c5793133d24c9caa4ec3eb69..89d117043b3b7eb1a4d53b18228df66e7409dace 100644 (file)
--- a/src/conf/checkpoint_conf.c
+++ b/src/conf/checkpoint_conf.c
@@ -502,7 +502,7 @@ virDomainCheckpointDefFormat(virDomainCheckpointDefPtr def,
                              virDomainXMLOptionPtr xmlopt,
                              unsigned int flags)
 {
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
 
     virCheckFlags(VIR_DOMAIN_CHECKPOINT_FORMAT_SECURE |
                   VIR_DOMAIN_CHECKPOINT_FORMAT_NO_DOMAIN |

diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c
index a1514c2e14863fa87c5969421195d22d3e32f620..12862a29860593aaeb34c319fb5c0a1d92df0b7f 100644 (file)
--- a/src/conf/cpu_conf.c
+++ b/src/conf/cpu_conf.c
@@ -668,7 +668,7 @@ char *
 virCPUDefFormat(virCPUDefPtr def,
                 virDomainNumaPtr numa)
 {
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
 
     if (virCPUDefFormatBufFull(&buf, def, numa) < 0)
         goto cleanup;
@@ -676,7 +676,6 @@ virCPUDefFormat(virCPUDefPtr def,
     return virBufferContentAndReset(&buf);
 
  cleanup:
-    virBufferFreeAndReset(&buf);
     return NULL;
 }
 
@@ -687,8 +686,8 @@ virCPUDefFormatBufFull(virBufferPtr buf,
                        virDomainNumaPtr numa)
 {
     int ret = -1;
-    virBuffer attributeBuf = VIR_BUFFER_INITIALIZER;
-    virBuffer childrenBuf = VIR_BUFFER_INIT_CHILD(buf);
+    g_auto(virBuffer) attributeBuf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) childrenBuf = VIR_BUFFER_INIT_CHILD(buf);
 
     if (!def)
         return 0;
@@ -755,8 +754,6 @@ virCPUDefFormatBufFull(virBufferPtr buf,
 
     ret = 0;
  cleanup:
-    virBufferFreeAndReset(&attributeBuf);
-    virBufferFreeAndReset(&childrenBuf);
     return ret;
 }
 

diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c
index 2f9ff899d7f293caed16c4d63189bea79358e0f2..1068cbf1d28226d047493525da69afe983c78849 100644 (file)
--- a/src/conf/domain_addr.c
+++ b/src/conf/domain_addr.c
@@ -1941,7 +1941,7 @@ virDomainUSBAddressPortFormatBuf(virBufferPtr buf,
 static char * ATTRIBUTE_NONNULL(1)
 virDomainUSBAddressPortFormat(unsigned int *port)
 {
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
     virDomainUSBAddressPortFormatBuf(&buf, port);
     return virBufferContentAndReset(&buf);
 }

diff --git a/src/conf/domain_capabilities.c b/src/conf/domain_capabilities.c
index 0fa8aee78e1bc709860e99a8a7bb46163df65459..837b004334d023823558690e6f2e04dc1908e086 100644 (file)
--- a/src/conf/domain_capabilities.c
+++ b/src/conf/domain_capabilities.c
@@ -596,7 +596,7 @@ virDomainCapsFormatFeatures(const virDomainCaps *caps,
 char *
 virDomainCapsFormat(const virDomainCaps *caps)
 {
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
     const char *virttype_str = virDomainVirtTypeToString(caps->virttype);
     const char *arch_str = virArchToString(caps->arch);
 

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index abea23542ac428acd7d5bdf33726440c6c3a4df5..37d4ccf9557e20b01ced3ca3708d9b2a51d864ab 100644 (file)
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -25264,7 +25264,7 @@ static int
 virDomainDiskDefFormatIotune(virBufferPtr buf,
                              virDomainDiskDefPtr disk)
 {
-    virBuffer childBuf = VIR_BUFFER_INIT_CHILD(buf);
+    g_auto(virBuffer) childBuf = VIR_BUFFER_INIT_CHILD(buf);
 
     FORMAT_IOTUNE(total_bytes_sec);
     FORMAT_IOTUNE(read_bytes_sec);
@@ -25309,7 +25309,7 @@ static int
 virDomainDiskDefFormatDriver(virBufferPtr buf,
                              virDomainDiskDefPtr disk)
 {
-    virBuffer driverBuf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) driverBuf = VIR_BUFFER_INITIALIZER;
 
     virBufferEscapeString(&driverBuf, " name='%s'", virDomainDiskGetDriver(disk));
 
@@ -26293,7 +26293,7 @@ static int
 virDomainVirtioNetGuestOptsFormat(char **outstr,
                                   virDomainNetDefPtr def)
 {
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
     if (def->driver.virtio.guest.csum) {
         virBufferAsprintf(&buf, "csum='%s' ",
                           virTristateSwitchTypeToString(def->driver.virtio.guest.csum));
@@ -26325,7 +26325,7 @@ static int
 virDomainVirtioNetHostOptsFormat(char **outstr,
                                  virDomainNetDefPtr def)
 {
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
     if (def->driver.virtio.host.csum) {
         virBufferAsprintf(&buf, "csum='%s' ",
                           virTristateSwitchTypeToString(def->driver.virtio.host.csum));
@@ -26365,7 +26365,7 @@ static int
 virDomainVirtioNetDriverFormat(char **outstr,
                                virDomainNetDefPtr def)
 {
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
     if (def->driver.virtio.name) {
         virBufferAsprintf(&buf, " name='%s'",
                           virDomainNetBackendTypeToString(def->driver.virtio.name));
@@ -29997,7 +29997,7 @@ virDomainDefFormat(virDomainDefPtr def,
                    virDomainXMLOptionPtr xmlopt,
                    unsigned int flags)
 {
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
 
     virCheckFlags(VIR_DOMAIN_DEF_FORMAT_COMMON_FLAGS, NULL);
     if (virDomainDefFormatInternal(def, xmlopt, &buf, flags) < 0)

diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c
index be5e1133a2f42df36ca6da64a63cf6383df4b3a4..76f705472144825c375a9b4c09dadcbb5d4596d7 100644 (file)
--- a/src/conf/interface_conf.c
+++ b/src/conf/interface_conf.c
@@ -1122,11 +1122,10 @@ virInterfaceDefDevFormat(virBufferPtr buf,
 char *
 virInterfaceDefFormat(const virInterfaceDef *def)
 {
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
 
-    if (virInterfaceDefDevFormat(&buf, def, VIR_INTERFACE_TYPE_LAST) < 0) {
-        virBufferFreeAndReset(&buf);
+    if (virInterfaceDefDevFormat(&buf, def, VIR_INTERFACE_TYPE_LAST) < 0)
         return NULL;
-    }
+
     return virBufferContentAndReset(&buf);
 }

diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index 4ebad1483cc0ca50fa7498483785ba519bbfddc2..99f11fdf0598e01e68005b1b54202838ff73f5e0 100644 (file)
--- a/src/conf/network_conf.c
+++ b/src/conf/network_conf.c
@@ -2718,7 +2718,7 @@ virNetworkDefFormat(const virNetworkDef *def,
                     virNetworkXMLOptionPtr xmlopt,
                     unsigned int flags)
 {
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
 
     if (virNetworkDefFormatBuf(&buf, def, xmlopt, flags) < 0)
         goto error;
@@ -2726,7 +2726,6 @@ virNetworkDefFormat(const virNetworkDef *def,
     return virBufferContentAndReset(&buf);
 
  error:
-    virBufferFreeAndReset(&buf);
     return NULL;
 }
 

diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
index 78a537d0ea33ef3531a8b3c9de1a7232f8c991f2..c54015336acce4379c9a461d3ff8ba91c2528a76 100644 (file)
--- a/src/conf/node_device_conf.c
+++ b/src/conf/node_device_conf.c
@@ -520,7 +520,7 @@ virNodeDeviceCapMdevDefFormat(virBufferPtr buf,
 char *
 virNodeDeviceDefFormat(const virNodeDeviceDef *def)
 {
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
     virNodeDevCapsDefPtr caps;
     size_t i = 0;
 

diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c
index 732c05ac89b089c8e755a9804c5c7258aee0c5bc..3827c65462bc6d14fbf8331095157f94701c834f 100644 (file)
--- a/src/conf/nwfilter_conf.c
+++ b/src/conf/nwfilter_conf.c
@@ -948,7 +948,7 @@ printTCPFlags(virBufferPtr buf,
 char *
 virNWFilterPrintTCPFlags(uint8_t flags)
 {
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
     printTCPFlags(&buf, flags);
     return virBufferContentAndReset(&buf);
 }
@@ -2561,7 +2561,7 @@ virNWFilterIsAllowedChain(const char *chainname)
     virNWFilterChainSuffixType i;
     const char *name;
     char *msg;
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
     bool printed = false;
 
     if (!virNWFilterIsValidChainName(chainname))
@@ -3044,7 +3044,7 @@ virNWFilterEntryFormat(virBufferPtr buf,
 char *
 virNWFilterDefFormat(const virNWFilterDef *def)
 {
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
     char uuid[VIR_UUID_STRING_BUFLEN];
     size_t i;
 
@@ -3071,7 +3071,6 @@ virNWFilterDefFormat(const virNWFilterDef *def)
     return virBufferContentAndReset(&buf);
 
  err_exit:
-    virBufferFreeAndReset(&buf);
     return NULL;
 }
 

diff --git a/src/conf/secret_conf.c b/src/conf/secret_conf.c
index 0ec9bce98781779badeb2d497d2f6c60066883de..3960cf04adfef3e63cd2ed7471e2d35dd3d5e2dd 100644 (file)
--- a/src/conf/secret_conf.c
+++ b/src/conf/secret_conf.c
@@ -277,7 +277,7 @@ virSecretDefFormatUsage(virBufferPtr buf,
 char *
 virSecretDefFormat(const virSecretDef *def)
 {
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
     const unsigned char *uuid;
     char uuidstr[VIR_UUID_STRING_BUFLEN];
 
@@ -301,6 +301,5 @@ virSecretDefFormat(const virSecretDef *def)
     return virBufferContentAndReset(&buf);
 
  error:
-    virBufferFreeAndReset(&buf);
     return NULL;
 }

diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c
index f73eeb06c760a6c0cd490fd5308ea1a191c4f7a3..9767592bfc9ca79ad29f772bea10a99be777a056 100644 (file)
--- a/src/conf/snapshot_conf.c
+++ b/src/conf/snapshot_conf.c
@@ -927,7 +927,7 @@ virDomainSnapshotDefFormat(const char *uuidstr,
                            virDomainXMLOptionPtr xmlopt,
                            unsigned int flags)
 {
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
 
     virCheckFlags(VIR_DOMAIN_SNAPSHOT_FORMAT_SECURE |
                   VIR_DOMAIN_SNAPSHOT_FORMAT_INTERNAL |

diff --git a/src/conf/storage_capabilities.c b/src/conf/storage_capabilities.c
index 1a3417f90bd9ee96cd2efe34b5136ae237fc73ae..cac238c4f2dad2486d25ca1d41e1c139c21e1076 100644 (file)
--- a/src/conf/storage_capabilities.c
+++ b/src/conf/storage_capabilities.c
@@ -117,16 +117,14 @@ virStoragePoolCapsFormatPool(virBufferPtr buf,
 char *
 virStoragePoolCapsFormat(const virStoragePoolCaps *caps)
 {
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
     size_t i;
 
     virBufferAddLit(&buf, "<storagepoolCapabilities>\n");
     virBufferAdjustIndent(&buf, 2);
     for (i = 0; i < VIR_STORAGE_POOL_LAST; i++) {
-        if (virStoragePoolCapsFormatPool(&buf, i, caps) < 0) {
-            virBufferFreeAndReset(&buf);
+        if (virStoragePoolCapsFormatPool(&buf, i, caps) < 0)
             return NULL;
-        }
     }
     virBufferAdjustIndent(&buf, -2);
     virBufferAddLit(&buf, "</storagepoolCapabilities>\n");

diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index 5669b92f8ddd5102e7edbc3484653d435658ac10..7bc743887ce52b7ea30a64be30d7e320a0934801 100644 (file)
--- a/src/conf/storage_conf.c
+++ b/src/conf/storage_conf.c
@@ -1223,7 +1223,7 @@ virStoragePoolDefFormatBuf(virBufferPtr buf,
 char *
 virStoragePoolDefFormat(virStoragePoolDefPtr def)
 {
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
 
     if (virStoragePoolDefFormatBuf(&buf, def) < 0)
         goto error;
@@ -1231,7 +1231,6 @@ virStoragePoolDefFormat(virStoragePoolDefPtr def)
     return virBufferContentAndReset(&buf);
 
  error:
-    virBufferFreeAndReset(&buf);
     return NULL;
 }
 
@@ -1594,7 +1593,7 @@ virStorageVolDefFormat(virStoragePoolDefPtr pool,
                        virStorageVolDefPtr def)
 {
     virStorageVolOptionsPtr options;
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
 
     options = virStorageVolOptionsForPoolType(pool->type);
     if (options == NULL)
@@ -1663,7 +1662,6 @@ virStorageVolDefFormat(virStoragePoolDefPtr pool,
     return virBufferContentAndReset(&buf);
 
  cleanup:
-    virBufferFreeAndReset(&buf);
     return NULL;
 }
 
@@ -1686,7 +1684,7 @@ int
 virStoragePoolSaveState(const char *stateFile,
                         virStoragePoolDefPtr def)
 {
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
     g_autofree char *xml = NULL;
 
     virBufferAddLit(&buf, "<poolstate>\n");
@@ -1743,7 +1741,7 @@ char *
 virStoragePoolSourceListFormat(virStoragePoolSourceListPtr def)
 {
     virStoragePoolOptionsPtr options;
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
     const char *type;
     size_t i;
 
@@ -1770,6 +1768,5 @@ virStoragePoolSourceListFormat(virStoragePoolSourceListPtr def)
     return virBufferContentAndReset(&buf);
 
  cleanup:
-    virBufferFreeAndReset(&buf);
     return NULL;
 }

diff --git a/src/conf/virnetworkobj.c b/src/conf/virnetworkobj.c
index b2affaacd38980c55092e5e1ef06497b6c22f34d..5d90dec2bc865e2ab2b2a41de86b2c1f68850c1f 100644 (file)
--- a/src/conf/virnetworkobj.c
+++ b/src/conf/virnetworkobj.c
@@ -815,7 +815,7 @@ virNetworkObjFormat(virNetworkObjPtr obj,
                     virNetworkXMLOptionPtr xmlopt,
                     unsigned int flags)
 {
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
     char *classIdStr = virBitmapFormat(obj->classIdMap);
     size_t i;
 
@@ -843,7 +843,6 @@ virNetworkObjFormat(virNetworkObjPtr obj,
     return virBufferContentAndReset(&buf);
 
  error:
-    virBufferFreeAndReset(&buf);
     return NULL;
 }
 

diff --git a/src/conf/virnetworkportdef.c b/src/conf/virnetworkportdef.c
index 2013e11dffb7ac4d6352f6f76ae0373157025e4d..1db3dc69e29e8269596d71933494f0bb89d94df0 100644 (file)
--- a/src/conf/virnetworkportdef.c
+++ b/src/conf/virnetworkportdef.c
@@ -324,12 +324,10 @@ virNetworkPortDefParseFile(const char *filename)
 char *
 virNetworkPortDefFormat(const virNetworkPortDef *def)
 {
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
 
-    if (virNetworkPortDefFormatBuf(&buf, def) < 0) {
-        virBufferFreeAndReset(&buf);
+    if (virNetworkPortDefFormatBuf(&buf, def) < 0)
         return NULL;
-    }
 
     return virBufferContentAndReset(&buf);
 }

diff --git a/src/conf/virnwfilterbindingdef.c b/src/conf/virnwfilterbindingdef.c
index 7d813353eff668edd70537722faf86e5accca9f7..f286bdd840cedf03059f3089ebf8312a3ff5c2dd 100644 (file)
--- a/src/conf/virnwfilterbindingdef.c
+++ b/src/conf/virnwfilterbindingdef.c
@@ -223,12 +223,10 @@ virNWFilterBindingDefParseFile(const char *filename)
 char *
 virNWFilterBindingDefFormat(const virNWFilterBindingDef *def)
 {
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
 
-    if (virNWFilterBindingDefFormatBuf(&buf, def) < 0) {
-        virBufferFreeAndReset(&buf);
+    if (virNWFilterBindingDefFormatBuf(&buf, def) < 0)
         return NULL;
-    }
 
     return virBufferContentAndReset(&buf);
 }

diff --git a/src/conf/virnwfilterbindingobj.c b/src/conf/virnwfilterbindingobj.c
index 7cfc2e9efa303b857d41d5e6f23f10407ff9a3d2..584721f8b63d7854c6baf595b70bb8a5ea1e51bb 100644 (file)
--- a/src/conf/virnwfilterbindingobj.c
+++ b/src/conf/virnwfilterbindingobj.c
@@ -284,16 +284,14 @@ virNWFilterBindingObjParseFile(const char *filename)
 char *
 virNWFilterBindingObjFormat(const virNWFilterBindingObj *obj)
 {
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
 
     virBufferAddLit(&buf, "<filterbindingstatus>\n");
 
     virBufferAdjustIndent(&buf, 2);
 
-    if (virNWFilterBindingDefFormatBuf(&buf, obj->def) < 0) {
-        virBufferFreeAndReset(&buf);
+    if (virNWFilterBindingDefFormatBuf(&buf, obj->def) < 0)
         return NULL;
-    }
 
     virBufferAdjustIndent(&buf, -2);
     virBufferAddLit(&buf, "</filterbindingstatus>\n");

diff --git a/src/conf/virsavecookie.c b/src/conf/virsavecookie.c
index 7fc951afe26991675cc9f035ecff0fbe6a36c0df..429daf69be9c4272bdc755f1f6c400d427545cb3 100644 (file)
--- a/src/conf/virsavecookie.c
+++ b/src/conf/virsavecookie.c
@@ -127,7 +127,7 @@ char *
 virSaveCookieFormat(virObjectPtr obj,
                     virSaveCookieCallbacksPtr saveCookie)
 {
-    virBuffer buf = VIR_BUFFER_INITIALIZER;
+    g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
 
     if (virSaveCookieFormatBuf(&buf, obj, saveCookie) < 0)
         goto error;
@@ -135,6 +135,5 @@ virSaveCookieFormat(virObjectPtr obj,
     return virBufferContentAndReset(&buf);
 
  error:
-    virBufferFreeAndReset(&buf);
     return NULL;
 }