]> xenbits.xensource.com Git - libvirt.git/commitdiff
parallels: Resolve Coverity USE_AFTER_FREE
authorJohn Ferlan <jferlan@redhat.com>
Wed, 27 Aug 2014 11:32:11 +0000 (07:32 -0400)
committerJohn Ferlan <jferlan@redhat.com>
Wed, 27 Aug 2014 16:52:26 +0000 (12:52 -0400)
Coverity complains that calling virNetworkDefFree(def), then jumping
to the cleanup: label which calls virNetworkDefFree(def) could result
in a double_free.  Just remove the call from the if statement.

src/parallels/parallels_network.c

index a45acdc0805ee26884d1644722de6dd9221c0366..f41c97f89cd1c810d4cc23f3ab7704ce36cbdaf5 100644 (file)
@@ -226,10 +226,8 @@ parallelsLoadNetwork(parallelsConnPtr privconn, virJSONValuePtr jobj)
         goto cleanup;
     }
 
-    if (!(net = virNetworkAssignDef(&privconn->networks, def, false))) {
-        virNetworkDefFree(def);
+    if (!(net = virNetworkAssignDef(&privconn->networks, def, false)))
         goto cleanup;
-    }
     net->active = 1;
     net->autostart = 1;
     virNetworkObjUnlock(net);