]> xenbits.xensource.com Git - libvirt.git/commitdiff
test_driver: validate @source in testDomainInterfaceAddresses
authorIlias Stamatis <stamatis.iliass@gmail.com>
Wed, 19 Jun 2019 11:18:15 +0000 (13:18 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 19 Jun 2019 13:48:50 +0000 (15:48 +0200)
Signed-off-by: Ilias Stamatis <stamatis.iliass@gmail.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/test/test_driver.c

index b95aaf41ca48ec3c10aeee97d2f455f36ad35c9b..2a0ffbc6c5e41474b49c83fd0b20338dc8349359 100755 (executable)
@@ -3417,7 +3417,7 @@ static int testDomainBlockStats(virDomainPtr domain,
 static int
 testDomainInterfaceAddresses(virDomainPtr dom,
                              virDomainInterfacePtr **ifaces,
-                             unsigned int source ATTRIBUTE_UNUSED,
+                             unsigned int source,
                              unsigned int flags)
 {
     size_t i;
@@ -3430,6 +3430,13 @@ testDomainInterfaceAddresses(virDomainPtr dom,
 
     virCheckFlags(0, -1);
 
+    if (source >= VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_LAST) {
+        virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED,
+                       _("Unknown IP address data source %d"),
+                       source);
+        return -1;
+    }
+
     if (!(vm = testDomObjFromDomain(dom)))
         goto cleanup;