]> xenbits.xensource.com Git - xen.git/commitdiff
x86: If e820 map overflows, leak memory in a safe manner.
authorKeir Fraser <keir@xensource.com>
Thu, 27 Sep 2007 15:50:52 +0000 (16:50 +0100)
committerKeir Fraser <keir@xensource.com>
Thu, 27 Sep 2007 15:50:52 +0000 (16:50 +0100)
Signed-off-by: Keir Fraser <keir@xensource.com>
xen/arch/x86/e820.c

index e678a4be5251ff39f427e745085e6d375d1bd83a..2fbfa8716070528e90a3880e7b7cedcafa2f49e3 100644 (file)
@@ -416,11 +416,9 @@ int __init reserve_e820_ram(struct e820map *e820, uint64_t s, uint64_t e)
         /* Truncate end. */
         e820->map[i].size -= e - s;
     }
-    else
+    else if ( e820->nr_map < ARRAY_SIZE(e820->map) )
     {
         /* Split in two. */
-        if ( e820->nr_map >= ARRAY_SIZE(e820->map) )
-            return 0;
         memmove(&e820->map[i+1], &e820->map[i],
                 (e820->nr_map-i) * sizeof(e820->map[0]));
         e820->nr_map++;
@@ -429,6 +427,21 @@ int __init reserve_e820_ram(struct e820map *e820, uint64_t s, uint64_t e)
         e820->map[i].addr = e;
         e820->map[i].size = re - e;
     }
+    else
+    {
+        /* e820map is at maximum size. We have to leak some space. */
+        if ( (s - rs) > (re - e) )
+        {
+            printk("e820 overflow: leaking RAM %"PRIx64"-%"PRIx64"\n", e, re);
+            e820->map[i].size = s - rs;
+        }
+        else
+        {
+            printk("e820 overflow: leaking RAM %"PRIx64"-%"PRIx64"\n", rs, s);
+            e820->map[i].addr = e;
+            e820->map[i].size = re - e;
+        }
+    }
 
     return 1;
 }