]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: avoid NULL deref on error
authorEric Blake <eblake@redhat.com>
Tue, 15 Feb 2011 00:34:05 +0000 (17:34 -0700)
committerEric Blake <eblake@redhat.com>
Tue, 15 Feb 2011 00:34:05 +0000 (17:34 -0700)
* src/qemu/qemu_command.c (qemuParseCommandLineDisk): Report error
before cleaning def.

src/qemu/qemu_command.c

index 3ba095049d95082245298b2576e36528a137fe34..1687203245df43afe2e301f71f6c6604f01f61e0 100644 (file)
@@ -4603,9 +4603,10 @@ qemuParseCommandLineDisk(virCapsPtr caps,
                     host = def->src + strlen("nbd:");
                     port = strchr(host, ':');
                     if (!port) {
-                        def = NULL;
                         qemuReportError(VIR_ERR_INTERNAL_ERROR,
-                                        _("cannot parse nbd filename '%s'"), def->src);
+                                        _("cannot parse nbd filename '%s'"),
+                                        def->src);
+                        def = NULL;
                         goto cleanup;
                     }
                     *port++ = '\0';