]> xenbits.xensource.com Git - unikraft/unikraft.git/commitdiff
plat/common/acpi: Fix `VGIC IRQ MODE` flag bitfield of `GICC`
authorSergiu Moga <sergiu@unikraft.io>
Sat, 23 Sep 2023 11:58:13 +0000 (14:58 +0300)
committerRazvan Deaconescu <razvand@unikraft.io>
Fri, 20 Oct 2023 16:35:55 +0000 (19:35 +0300)
The bitfield `ACPI_MADT_GICC_FLAGS_VGIC_IRQ_MODE` of `GICC` had
the wrong value: it may be the 3rd bit from right to left, but its
corresponding value is 4 (1 << 2) not 3.

Signed-off-by: Sergiu Moga <sergiu@unikraft.io>
Reviewed-by: Michalis Pappas <michalis@unikraft.io>
Reviewed-by: Razvan Virtan <virtanrazvan@gmail.com>
Approved-by: Razvan Deaconescu <razvand@unikraft.io>
GitHub-Closes: #1120

plat/common/include/uk/plat/common/madt.h

index 1c57a8c51ed9a3769db8cc5f2bba043ebd75eb7d..aae94dda988074960df8c2239208954f6006f16e 100644 (file)
@@ -169,7 +169,7 @@ struct acpi_madt_x2apic_nmi {
 /* GIC CPU Interface (GICC) Structure */
 #define ACPI_MADT_GICC_FLAGS_EN                                        0x01
 #define ACPI_MADT_GICC_FLAGS_PERF_IRQ_MODE                     0x02
-#define ACPI_MADT_GICC_FLAGS_VGIC_IRQ_MODE                     0x03
+#define ACPI_MADT_GICC_FLAGS_VGIC_IRQ_MODE                     0x04
 struct acpi_madt_gicc {
        struct acpi_subsdt_hdr hdr;
        __u16 reserved;