]> xenbits.xensource.com Git - xen.git/commitdiff
tools/libxc: Fix missing break in xc_domain_bind_pt_irq()
authorAndrew Cooper <andrew.cooper3@citrix.com>
Wed, 18 Jun 2014 17:44:44 +0000 (18:44 +0100)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Mon, 23 Jun 2014 17:10:32 +0000 (18:10 +0100)
c/s 568da4f8 "pt-irq fixes and improvements" accidentally forgot a break when
refactoring xc_domain_bind_pt_irq() which results in bind->u.pci.bus being
clobbered by isa_irq for PCI and MSI_TRANSLATE interrupts.

Coverity-ID: 1223210
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Jan Beulich <JBeulich@suse.com>
CC: Ian Campbell <Ian.Campbell@citrix.com>
CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
tools/libxc/xc_domain.c

index ef470a5ba19e1157784958f69f03e56ccdca9023..d5d6d12f742224757b1cdeacdb2c38b2bf0d6808 100644 (file)
@@ -1711,6 +1711,7 @@ int xc_domain_bind_pt_irq(
         bind->u.pci.bus = bus;
         bind->u.pci.device = device;
         bind->u.pci.intx = intx;
+        break;
     case PT_IRQ_TYPE_ISA:
         bind->u.isa.isa_irq = isa_irq;
         break;