]> xenbits.xensource.com Git - libvirt.git/commitdiff
Avoid uninitialized data in qemuMonitorTestNew
authorDaniel P. Berrange <berrange@redhat.com>
Wed, 25 Sep 2013 14:30:27 +0000 (15:30 +0100)
committerDaniel P. Berrange <berrange@redhat.com>
Wed, 25 Sep 2013 17:12:09 +0000 (18:12 +0100)
The virDomainChrSourceDef variable should be memset to
0, so that the cleanup block does not free uninitialized
data on OOM.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
tests/qemumonitortestutils.c

index 956847667cb2191ed72bf1527a346e7bdd769472..bca338541c6181f0fa3a5ce87c2abc0ccad7e212 100644 (file)
@@ -878,6 +878,8 @@ qemuMonitorTestNew(bool json,
     qemuMonitorTestPtr test = NULL;
     virDomainChrSourceDef src;
 
+    memset(&src, 0, sizeof(src));
+
     if (!(test = qemuMonitorCommonTestNew(xmlopt, vm, &src)))
         goto error;
 
@@ -915,6 +917,8 @@ qemuMonitorTestNewAgent(virDomainXMLOptionPtr xmlopt)
     qemuMonitorTestPtr test = NULL;
     virDomainChrSourceDef src;
 
+    memset(&src, 0, sizeof(src));
+
     if (!(test = qemuMonitorCommonTestNew(xmlopt, NULL, &src)))
         goto error;