]> xenbits.xensource.com Git - xen.git/commitdiff
rombios/tcgbios: initialise logdataptr in HashLogEvent32
authorWei Liu <wei.liu2@citrix.com>
Fri, 29 Apr 2016 15:11:14 +0000 (16:11 +0100)
committerWei Liu <wei.liu2@citrix.com>
Fri, 6 May 2016 14:50:20 +0000 (15:50 +0100)
Gcc complains:

tcgbios.c: In function ‘HashLogEvent32’:
tcgbios.c:1131:10: error: ‘logdataptr’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
    entry = tcpa_extend_acpi_log(logdataptr);

It fails to figure out when logdataptr is used it is always initialised
in a if block a few line above.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: Doug Goldstein <cardoe@cardoe.com>
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
tools/firmware/rombios/32bit/tcgbios/tcgbios.c

index 350105107c07270a9c3fd8caee0888e85284776f..fa22c4460aac6f45aa67ceb991033c93b25a84fa 100644 (file)
@@ -1062,7 +1062,7 @@ uint32_t HashLogEvent32(struct hlei *hlei, struct hleo *hleo,
 {
        uint32_t rc = 0;
        uint16_t size;
-       uint32_t logdataptr;
+       uint32_t logdataptr = 0;
        uint32_t logdatalen;
        uint32_t hashdataptr;
        uint32_t hashdatalen;