]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: deprecate QEMU_CAPS_RTC_TD_HACK
authorJán Tomko <jtomko@redhat.com>
Thu, 29 Mar 2018 10:51:55 +0000 (12:51 +0200)
committerJán Tomko <jtomko@redhat.com>
Mon, 16 Apr 2018 12:56:49 +0000 (14:56 +0200)
Implied by QEMU >= 0.12.0.

Deprecated by QEMU commit 1ed2fc1 included in 0.12.0.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
src/qemu/qemu_capabilities.h
src/qemu/qemu_command.c

index 4d15fc50d1f4ad56a6ed29f25289f1bfa5c68368..75f389fd2d0fdbdf256caa81866cb4b9b66b90e2 100644 (file)
@@ -92,7 +92,7 @@ typedef enum {
     /* 30 */
     X_QEMU_CAPS_RTC, /* The -rtc flag for clock options */
     QEMU_CAPS_VHOST_NET, /* vhost-net support available */
-    QEMU_CAPS_RTC_TD_HACK, /* -rtc-td-hack available */
+    X_QEMU_CAPS_RTC_TD_HACK, /* -rtc-td-hack available */
     QEMU_CAPS_NO_HPET, /* -no-hpet flag is supported */
     QEMU_CAPS_NO_KVM_PIT, /* -no-kvm-pit-reinjection supported */
 
index 3c28951d8d28275d03fb0fd873ea57518a6d48c2..314b20f30e4e4d5cb1d317e24aba676ca2286609 100644 (file)
@@ -6181,26 +6181,7 @@ qemuBuildClockCommandLine(virCommandPtr cmd,
             break;
 
         case VIR_DOMAIN_TIMER_NAME_RTC:
-            /* This has already been taken care of (in qemuBuildClockArgStr)
-               if QEMU_CAPS_RTC is set (mutually exclusive with
-               QEMUD_FLAG_RTC_TD_HACK) */
-            if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_RTC_TD_HACK)) {
-                switch (def->clock.timers[i]->tickpolicy) {
-                case -1:
-                case VIR_DOMAIN_TIMER_TICKPOLICY_DELAY:
-                    /* the default - do nothing */
-                    break;
-                case VIR_DOMAIN_TIMER_TICKPOLICY_CATCHUP:
-                    virCommandAddArg(cmd, "-rtc-td-hack");
-                    break;
-                case VIR_DOMAIN_TIMER_TICKPOLICY_MERGE:
-                case VIR_DOMAIN_TIMER_TICKPOLICY_DISCARD:
-                    virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
-                                   _("unsupported rtc tickpolicy '%s'"),
-                                   virDomainTimerTickpolicyTypeToString(def->clock.timers[i]->tickpolicy));
-                    return -1;
-                }
-            }
+            /* Already handled in qemuBuildClockArgStr */
             break;
 
         case VIR_DOMAIN_TIMER_NAME_PIT: