]> xenbits.xensource.com Git - xen.git/commitdiff
tools/libs/light: set video_mem for PVH guests
authorJuergen Gross <jgross@suse.com>
Fri, 3 Dec 2021 07:30:58 +0000 (08:30 +0100)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Thu, 9 Dec 2021 16:26:29 +0000 (16:26 +0000)
The size of the video memory of PVH guests should be set to 0 in case
no value has been specified.

Doing not so will leave it to be -1, resulting in an additional 1 kB
of RAM being advertised in the memory map (here the output of a PVH
Mini-OS boot with 16 MB of RAM assigned):

Memory map:
000000000000-0000010003ff: RAM
0000feff8000-0000feffffff: Reserved
0000fc008000-0000fc00803f: ACPI
0000fc000000-0000fc000fff: ACPI
0000fc001000-0000fc007fff: ACPI

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
tools/libs/light/libxl_create.c

index dcd09d32ba0b7f3e21e7faa4381c582fc063da99..d7a40d7550f599e8cf78b9507d8ac2a0388b83ca 100644 (file)
@@ -427,6 +427,8 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
         break;
     case LIBXL_DOMAIN_TYPE_PVH:
         libxl_defbool_setdefault(&b_info->u.pvh.pvshim, false);
+        if (b_info->video_memkb == LIBXL_MEMKB_DEFAULT)
+            b_info->video_memkb = 0;
         if (libxl_defbool_val(b_info->u.pvh.pvshim)) {
             if (!b_info->u.pvh.pvshim_path)
                 b_info->u.pvh.pvshim_path =