]> xenbits.xensource.com Git - libvirt.git/commitdiff
virt-nss: Introduce more checks before enabling NSS
authorMichal Privoznik <mprivozn@redhat.com>
Sun, 25 Dec 2016 12:42:42 +0000 (13:42 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 2 Jan 2017 12:25:42 +0000 (13:25 +0100)
The plugin depends on more modules than we currently check for,
i.e. network driver and yajl library.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
configure.ac
m4/virt-nss.m4

index 9a050757744b6472bb00ddd2167c947c22eb5d24..c67ba79c74af303cc337950e7118cb8869a80a3d 100644 (file)
@@ -294,7 +294,6 @@ LIBVIRT_CHECK_LIBSSH
 LIBVIRT_CHECK_LIBXML
 LIBVIRT_CHECK_MACVTAP
 LIBVIRT_CHECK_NETCF
-LIBVIRT_CHECK_NSS
 LIBVIRT_CHECK_NUMACTL
 LIBVIRT_CHECK_NWFILTER
 LIBVIRT_CHECK_OPENWSMAN
@@ -479,6 +478,7 @@ LIBVIRT_CHECK_LOGIN_SHELL
 LIBVIRT_CHECK_HOST_VALIDATE
 LIBVIRT_CHECK_TLS_PRIORITY
 LIBVIRT_CHECK_SYSCTL_CONFIG
+LIBVIRT_CHECK_NSS
 
 
 
index f50b1b91c4cb87637eed94d6ed6f0adaf985687f..8840e7b243da7211e5e2053553ff077173076989 100644 (file)
@@ -27,16 +27,34 @@ AC_DEFUN([LIBVIRT_CHECK_NSS],[
   bsd_nss=no
   fail=0
   if test "x$with_nss_plugin" != "xno" ; then
-    AC_CHECK_HEADERS([nss.h], [
-        with_nss_plugin=yes
-      ],[
-        if test "x$with_nss_plugin" = "xyes" ; then
-          fail = 1
-        fi
-      ])
+    if test "x$with_yajl" != "xyes" ; then
+      if test "x$with_nss_plugin" = "xyes" ; then
+        AC_MSG_ERROR([Can't build nss plugin without yajl])
+      else
+        with_nss_plugin=no
+      fi
+    fi
+
+    if test "x$with_network" != "xyes" ; then
+      if test "x$with_nss_plugin" = "xyes" ; then
+        AC_MSG_ERROR([Can't build nss plugin without yajl])
+      else
+        with_nss_plugin=no
+      fi
+    fi
+
+    if test "x$with_nss_plugin" != "xno" ; then
+      AC_CHECK_HEADERS([nss.h], [
+          with_nss_plugin=yes
+        ],[
+          if test "x$with_nss_plugin" = "xyes" ; then
+            fail = 1
+          fi
+        ])
 
-    if test $fail = 1 ; then
-      AC_MSG_ERROR([Can't build nss plugin without nss.h])
+      if test $fail = 1 ; then
+        AC_MSG_ERROR([Can't build nss plugin without nss.h])
+      fi
     fi
 
     if test "x$with_nss_plugin" = "xyes" ; then