]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
parallels: don't forget to unlock domain after successful virDomainObjListFindByUUID...
authorMaxim Nestratov <mnestratov@parallels.com>
Wed, 22 Apr 2015 15:25:50 +0000 (18:25 +0300)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 22 Apr 2015 15:53:04 +0000 (17:53 +0200)
Also a typo is fixed (s/detached/attached/)

Signed-off-by: Maxim Nestratov mnestratov@parallels.com
src/parallels/parallels_driver.c

index d135ecdecb8789c1882d288564cee7514fd730e3..662bb386d71c3e96f4da9578e7c0bd2151670f2f 100644 (file)
@@ -1109,7 +1109,7 @@ static int parallelsDomainAttachDeviceFlags(virDomainPtr dom, const char *xml,
     privdom = virDomainObjListFindByUUID(privconn->domains, dom->uuid);
     if (privdom == NULL) {
         parallelsDomNotFoundError(dom);
-        goto cleanup;
+        return -1;
     }
 
     if (!(flags & VIR_DOMAIN_AFFECT_CONFIG)) {
@@ -1148,13 +1148,14 @@ static int parallelsDomainAttachDeviceFlags(virDomainPtr dom, const char *xml,
         break;
     default:
         virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
-                       _("device type '%s' cannot be detached"),
+                       _("device type '%s' cannot be attached"),
                        virDomainDeviceTypeToString(dev->type));
         break;
     }
 
     ret = 0;
  cleanup:
+    virObjectUnlock(privdom);
     return ret;
 }