Assign virtio-serial addresses after coldplugging a device

Otherwise we might allow coldplugging a device
that uses an address that is already occupied, creating
an unstartable domain.

https://bugzilla.redhat.com/show_bug.cgi?id=1220195

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index f922a2893c706f4571f504b018853cad8eb8ad95..f7433ee9b3aaaeac7e79e96c2606444086bbf13b 100644 (file)
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -8334,6 +8334,8 @@ qemuDomainAttachDeviceConfig(virQEMUCapsPtr qemuCaps,
         dev->data.chr = NULL;
         if (virDomainDefAddImplicitControllers(vmdef) < 0)
             return -1;
+        if (qemuDomainAssignAddresses(vmdef, qemuCaps, NULL) < 0)
+            return -1;
         break;
 
     case VIR_DOMAIN_DEVICE_FS: