]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: reuse qemuMigrationIsAllowed when doing save and managedsave
authorPeter Krempa <pkrempa@redhat.com>
Fri, 7 Dec 2012 11:12:56 +0000 (12:12 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 11 Dec 2012 18:48:37 +0000 (19:48 +0100)
Save and managedsave both use migration to file. This patch reuses
qemuMigrationIsAllowed to check if the migration could happen before
trying.

src/qemu/qemu_driver.c

index 9a449bfbeba61dbc25b9d82b6b11e1b38e45bad8..2fda44e3e7f52cf2219df9891037f995eb4bd009 100644 (file)
@@ -3006,16 +3006,8 @@ qemuDomainSaveInternal(virQEMUDriverPtr driver, virDomainPtr dom,
     virDomainEventPtr event = NULL;
     qemuDomainObjPrivatePtr priv = vm->privateData;
 
-    if (qemuProcessAutoDestroyActive(driver, vm)) {
-        virReportError(VIR_ERR_OPERATION_INVALID,
-                       "%s", _("domain is marked for auto destroy"));
+    if (!qemuMigrationIsAllowed(driver, vm, vm->def, false))
         goto cleanup;
-    }
-    if (virDomainHasDiskMirror(vm)) {
-        virReportError(VIR_ERR_BLOCK_COPY_ACTIVE, "%s",
-                       _("domain has active block copy job"));
-        goto cleanup;
-    }
 
     if (qemuDomainObjBeginAsyncJobWithDriver(driver, vm,
                                              QEMU_ASYNC_JOB_SAVE) < 0)