]> xenbits.xensource.com Git - people/dariof/xen.git/commitdiff
xen/arm: vgic-v3: fix GICD_ISACTIVER range
authorPeng Fan <peng.fan@nxp.com>
Fri, 17 Apr 2020 22:16:09 +0000 (15:16 -0700)
committerStefano Stabellini <sstabellini@kernel.org>
Tue, 21 Apr 2020 19:10:50 +0000 (12:10 -0700)
The end should be GICD_ISACTIVERN not GICD_ISACTIVER.

See https://marc.info/?l=xen-devel&m=158527653730795 for a discussion on
what it would take to implement GICD_ISACTIVER/GICD_ICACTIVER properly.

We chose v1 instead of v2 of this patch to avoid spamming the console:
v2 adds a printk for every read, and reads can happen often.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
[Stefano: improve commit message]
Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
Acked-by: Julien Grall <jgrall@amazon.com>
xen/arch/arm/vgic-v3.c

index 4e60ba15cc9b8288a3cf2ac935f52c306531d1f1..fd8cfc156d0c5b3c67f21c7f6eece88d3e067b4b 100644 (file)
@@ -713,7 +713,7 @@ static int __vgic_v3_distr_common_mmio_read(const char *name, struct vcpu *v,
         goto read_as_zero;
 
     /* Read the active status of an IRQ via GICD/GICR is not supported */
-    case VRANGE32(GICD_ISACTIVER, GICD_ISACTIVER):
+    case VRANGE32(GICD_ISACTIVER, GICD_ISACTIVERN):
     case VRANGE32(GICD_ICACTIVER, GICD_ICACTIVERN):
         goto read_as_zero;