]> xenbits.xensource.com Git - people/royger/xen.git/commitdiff
tools/misc: xenwatchdogd: use EXIT_* constants
authorLeigh Brown <leigh@solinno.co.uk>
Fri, 29 Mar 2024 11:10:51 +0000 (11:10 +0000)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Thu, 11 Apr 2024 13:16:53 +0000 (14:16 +0100)
Use EXIT_SUCCESS/EXIT_FAILURE constants instead of magic numbers.

Signed-off-by: Leigh Brown <leigh@solinno.co.uk>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
tools/misc/xenwatchdogd.c

index 254117b554c59196cae120ab0a0505d15d5a704b..2f7c822d6149f4c15189d4485b80337296d07d70 100644 (file)
@@ -17,37 +17,37 @@ void daemonize(void)
 {
     switch (fork()) {
     case -1:
-       err(1, "fork");
+       err(EXIT_FAILURE, "fork");
     case 0:
        break;
     default:
-       exit(0);
+       exit(EXIT_SUCCESS);
     }
     umask(0);
     if (setsid() < 0)
-       err(1, "setsid");
+       err(EXIT_FAILURE, "setsid");
     if (chdir("/") < 0)
-       err(1, "chdir /");
+       err(EXIT_FAILURE, "chdir /");
     if (freopen("/dev/null", "r", stdin) == NULL)
-        err(1, "reopen stdin");
+        err(EXIT_FAILURE, "reopen stdin");
     if(freopen("/dev/null", "w", stdout) == NULL)
-        err(1, "reopen stdout");
+        err(EXIT_FAILURE, "reopen stdout");
     if(freopen("/dev/null", "w", stderr) == NULL)
-        err(1, "reopen stderr");
+        err(EXIT_FAILURE, "reopen stderr");
 }
 
 void catch_exit(int sig)
 {
     if (id)
         xc_watchdog(h, id, 300);
-    exit(0);
+    exit(EXIT_SUCCESS);
 }
 
 void catch_usr1(int sig)
 {
     if (id)
         xc_watchdog(h, id, 0);
-    exit(0);
+    exit(EXIT_SUCCESS);
 }
 
 int main(int argc, char **argv)
@@ -56,44 +56,44 @@ int main(int argc, char **argv)
     int ret;
 
     if (argc < 2)
-       errx(1, "usage: %s <timeout> <sleep>", argv[0]);
+       errx(EXIT_FAILURE, "usage: %s <timeout> <sleep>", argv[0]);
 
     daemonize();
 
     h = xc_interface_open(NULL, NULL, 0);
     if (h == NULL)
-       err(1, "xc_interface_open");
+       err(EXIT_FAILURE, "xc_interface_open");
 
     t = strtoul(argv[1], NULL, 0);
     if (t == ULONG_MAX)
-       err(1, "strtoul");
+       err(EXIT_FAILURE, "strtoul");
 
     s = t / 2;
     if (argc == 3) {
        s = strtoul(argv[2], NULL, 0);
        if (s == ULONG_MAX)
-           err(1, "strtoul");
+           err(EXIT_FAILURE, "strtoul");
     }
 
     if (signal(SIGHUP, &catch_exit) == SIG_ERR)
-       err(1, "signal");
+       err(EXIT_FAILURE, "signal");
     if (signal(SIGINT, &catch_exit) == SIG_ERR)
-       err(1, "signal");
+       err(EXIT_FAILURE, "signal");
     if (signal(SIGQUIT, &catch_exit) == SIG_ERR)
-       err(1, "signal");
+       err(EXIT_FAILURE, "signal");
     if (signal(SIGTERM, &catch_exit) == SIG_ERR)
-       err(1, "signal");
+       err(EXIT_FAILURE, "signal");
     if (signal(SIGUSR1, &catch_usr1) == SIG_ERR)
-       err(1, "signal");
+       err(EXIT_FAILURE, "signal");
 
     id = xc_watchdog(h, 0, t);
     if (id <= 0)
-        err(1, "xc_watchdog setup");
+        err(EXIT_FAILURE, "xc_watchdog setup");
 
     for (;;) {
         sleep(s);
         ret = xc_watchdog(h, id, t);
         if (ret != 0)
-            err(1, "xc_watchdog");
+            err(EXIT_FAILURE, "xc_watchdog");
     }
 }