]> xenbits.xensource.com Git - libvirt.git/commitdiff
virsh: Accept UUID as an argument for storage commands
authorOsier Yang <jyang@redhat.com>
Mon, 4 Jun 2012 08:35:34 +0000 (16:35 +0800)
committerOsier Yang <jyang@redhat.com>
Tue, 5 Jun 2012 06:56:35 +0000 (14:56 +0800)
Affected commands are: pool-start, vol-create-from.

tools/virsh.c

index 0e41d001fc945af6f88c398b38263c3153848dc7..61945248a06d637fd66d9b615934efcfb4d8fa1e 100644 (file)
@@ -11288,7 +11288,7 @@ static const vshCmdInfo info_pool_start[] = {
 };
 
 static const vshCmdOptDef opts_pool_start[] = {
-    {"pool", VSH_OT_DATA, VSH_OFLAG_REQ, N_("name of the inactive pool")},
+    {"pool", VSH_OT_DATA, VSH_OFLAG_REQ, N_("name or uuid of the inactive pool")},
     {NULL, 0, 0, NULL}
 };
 
@@ -11297,18 +11297,18 @@ cmdPoolStart(vshControl *ctl, const vshCmd *cmd)
 {
     virStoragePoolPtr pool;
     bool ret = true;
+    const char *name = NULL;
 
     if (!vshConnectionUsability(ctl, ctl->conn))
         return false;
 
-    if (!(pool = vshCommandOptPoolBy(ctl, cmd, "pool", NULL, VSH_BYNAME)))
+    if (!(pool = vshCommandOptPool(ctl, cmd, "pool", &name)))
          return false;
 
     if (virStoragePoolCreate(pool, 0) == 0) {
-        vshPrint(ctl, _("Pool %s started\n"),
-                 virStoragePoolGetName(pool));
+        vshPrint(ctl, _("Pool %s started\n"), name);
     } else {
-        vshError(ctl, _("Failed to start pool %s"), virStoragePoolGetName(pool));
+        vshError(ctl, _("Failed to start pool %s"), name);
         ret = false;
     }
 
@@ -11631,7 +11631,7 @@ static const vshCmdInfo info_vol_create_from[] = {
 };
 
 static const vshCmdOptDef opts_vol_create_from[] = {
-    {"pool", VSH_OT_DATA, VSH_OFLAG_REQ, N_("pool name")},
+    {"pool", VSH_OT_DATA, VSH_OFLAG_REQ, N_("pool name or uuid")},
     {"file", VSH_OT_DATA, VSH_OFLAG_REQ, N_("file containing an XML vol description")},
     {"vol", VSH_OT_DATA, VSH_OFLAG_REQ, N_("input vol name or key")},
     {"inputpool", VSH_OT_STRING, 0, N_("pool name or uuid of the input volume's pool")},
@@ -11650,7 +11650,7 @@ cmdVolCreateFrom(vshControl *ctl, const vshCmd *cmd)
     if (!vshConnectionUsability(ctl, ctl->conn))
         goto cleanup;
 
-    if (!(pool = vshCommandOptPoolBy(ctl, cmd, "pool", NULL, VSH_BYNAME)))
+    if (!(pool = vshCommandOptPool(ctl, cmd, "pool", NULL)))
         goto cleanup;
 
     if (vshCommandOptString(cmd, "file", &from) <= 0) {