]> xenbits.xensource.com Git - ovmf.git/commitdiff
RedfishPkg: Fix condition checking of error status
authorVu Nguyen <vunguyen@os.amperecomputing.com>
Wed, 30 Jun 2021 01:41:21 +0000 (08:41 +0700)
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Mon, 8 May 2023 13:12:01 +0000 (13:12 +0000)
This change fixes condition checking of error status, the condition
should be compared with TRUE status to be identical with an error message.

Signed-off-by: Minh Nguyen <minhnguyen1@os.amperecomputing.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Cc: Nick Ramirez <nramirez@nvidia.com>
Reviewed-by: Nickle Wang <nicklew@nvidia.com>
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c

index 0900a2479e7b088eb07de50f00f17d837ec7c936..14702748813b5d941a5d511e8fb444c49ddaf14d 100644 (file)
@@ -5,6 +5,7 @@
   (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR>\r
   Copyright (c) 2022, AMD Incorporated. All rights reserved.\r
   Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.\r
+  Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR>\r
 \r
   SPDX-License-Identifier: BSD-2-Clause-Patent\r
 \r
@@ -926,7 +927,7 @@ AddAndSignalNewRedfishService (
     }\r
 \r
     Status = gBS->SignalEvent (Instance->DiscoverToken->Event);\r
-    if (!EFI_ERROR (Status)) {\r
+    if (EFI_ERROR (Status)) {\r
       DEBUG ((DEBUG_ERROR, "%a:No event to signal!\n", __func__));\r
     }\r
   }\r