]> xenbits.xensource.com Git - libvirt.git/commitdiff
vbox: fix compilation error
authorRoman Bogorodskiy <bogorodskiy@gmail.com>
Tue, 10 Jun 2014 17:08:13 +0000 (21:08 +0400)
committerRoman Bogorodskiy <bogorodskiy@gmail.com>
Tue, 10 Jun 2014 17:30:44 +0000 (21:30 +0400)
clang complains about possibly uninitialized variable:

vbox/vbox_snapshot_conf.c:1355:9: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
    if (!(xPathContext = xmlXPathNewContext(xml))) {
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

So init 'ret' with NULL.

src/vbox/vbox_snapshot_conf.c

index 49096650af10fe9bcde2ff57da4d8d82da6124da..9c784103020a9e41608f03706b1fb08b8f5c9c90 100644 (file)
@@ -1336,7 +1336,7 @@ virVBoxSnapshotConfGetRODisksPathsFromLibvirtXML(const char *filePath,
 {
     int result = -1;
     size_t i = 0;
-    char **ret;
+    char **ret = NULL;
     xmlDocPtr xml = NULL;
     xmlXPathContextPtr xPathContext = NULL;
     xmlNodePtr *nodes = NULL;