use ARRAY_CARDINALITY more

* tests/nodeinfotest.c: Include "util.h".
* src/xen_internal.c: Likewise.
* src/qemu_conf.c (qemudCapsInit): Use ARRAY_CARDINALITY.
* src/storage_backend.c (virStorageBackendForType): Likewise.
* src/storage_backend_fs.c (virStorageBackendProbeFile): Likewise.
* src/xen_internal.c (xenHypervisorMakeCapabilitiesInternal): Likewise.
* src/xend_internal.c (xenDaemonParseSxpr): Likewise.
* tests/nodeinfotest.c (mymain): Likewise.
* tests/qparamtest.c (DO_TEST): Likewise.

diff --git a/ChangeLog b/ChangeLog
index 76ad0d6a1339758b5289dfbbd573505ef64cc984..959ae2bf4a4c9370213c2f2d5d405e7db240baef 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,16 @@
+Mon Oct 27 17:14:56 +0100 2008 Jim Meyering <meyering@redhat.com>
+
+       use ARRAY_CARDINALITY more
+       * tests/nodeinfotest.c: Include "util.h".
+       * src/xen_internal.c: Likewise.
+       * src/qemu_conf.c (qemudCapsInit): Use ARRAY_CARDINALITY.
+       * src/storage_backend.c (virStorageBackendForType): Likewise.
+       * src/storage_backend_fs.c (virStorageBackendProbeFile): Likewise.
+       * src/xen_internal.c (xenHypervisorMakeCapabilitiesInternal): Likewise.
+       * src/xend_internal.c (xenDaemonParseSxpr): Likewise.
+       * tests/nodeinfotest.c (mymain): Likewise.
+       * tests/qparamtest.c (DO_TEST): Likewise.
+
 Mon Oct 27 17:14:56 +0100 2008 Jim Meyering <meyering@redhat.com>
 
        exempt gnulib from write-avoidance syntax check

diff --git a/src/qemu_conf.c b/src/qemu_conf.c
index 7702090c50f25db76b87cc7839ef13f1b84c4d04..03b14f8462d1491af77fcb1384016222226d22ad 100644 (file)
--- a/src/qemu_conf.c
+++ b/src/qemu_conf.c
@@ -371,7 +371,7 @@ virCapsPtr qemudCapsInit(void) {
     if (qemudCapsInitNUMA(caps) < 0)
         goto no_memory;
 
-    for (i = 0 ; i < (sizeof(arch_info_hvm)/sizeof(arch_info_hvm[0])) ; i++)
+    for (i = 0 ; i < ARRAY_CARDINALITY(arch_info_hvm) ; i++)
         if (qemudCapsInitGuest(caps,
                                utsname.machine,
                                &arch_info_hvm[i], 1) < 0)
@@ -379,7 +379,7 @@ virCapsPtr qemudCapsInit(void) {
 
     if (access("/usr/bin/xenner", X_OK) == 0 &&
         access("/dev/kvm", F_OK) == 0) {
-        for (i = 0 ; i < (sizeof(arch_info_xen)/sizeof(arch_info_xen[0])) ; i++)
+        for (i = 0 ; i < ARRAY_CARDINALITY(arch_info_xen) ; i++)
             /* Allow Xen 32-on-32, 32-on-64 and 64-on-64 */
             if (STREQ(arch_info_xen[i].arch, utsname.machine) ||
                 (STREQ(utsname.machine, "x86_64") &&

diff --git a/src/storage_backend.c b/src/storage_backend.c
index de4efa7ad4157aa752add70c10688d0149df552d..e33f98c0511b2238b7ddfd2a34c8fd70d7f26eba 100644 (file)
--- a/src/storage_backend.c
+++ b/src/storage_backend.c
@@ -88,7 +88,7 @@ static virStorageBackendPtr backends[] = {
 virStorageBackendPtr
 virStorageBackendForType(int type) {
     unsigned int i;
-    for (i = 0 ; i < (sizeof(backends)/sizeof(backends[0])) ; i++)
+    for (i = 0 ; i < ARRAY_CARDINALITY(backends); i++)
         if (backends[i]->type == type)
             return backends[i];
 

diff --git a/src/storage_backend_fs.c b/src/storage_backend_fs.c
index c3bda715fda0ba943aa35f7c00a2c4e949c91f28..2ea9f93bdbb7b7cfeb2a98667350db806f9b8e56 100644 (file)
--- a/src/storage_backend_fs.c
+++ b/src/storage_backend_fs.c
@@ -210,7 +210,7 @@ static int virStorageBackendProbeFile(virConnectPtr conn,
     close(fd);
 
     /* First check file magic */
-    for (i = 0 ; i < sizeof(fileTypeInfo)/sizeof(fileTypeInfo[0]) ; i++) {
+    for (i = 0 ; i < ARRAY_CARDINALITY(fileTypeInfo) ; i++) {
         int mlen;
         if (fileTypeInfo[i].magic == NULL)
             continue;
@@ -276,7 +276,7 @@ static int virStorageBackendProbeFile(virConnectPtr conn,
     }
 
     /* No magic, so check file extension */
-    for (i = 0 ; i < sizeof(fileTypeInfo)/sizeof(fileTypeInfo[0]) ; i++) {
+    for (i = 0 ; i < ARRAY_CARDINALITY(fileTypeInfo) ; i++) {
         if (fileTypeInfo[i].extension == NULL)
             continue;
 

diff --git a/src/xen_internal.c b/src/xen_internal.c
index 5e34c257b886ff6ab3a0de5cc34d6bc74bb3e89f..72c61eb98d5f57102d06fdee33fa962083e86007 100644 (file)
--- a/src/xen_internal.c
+++ b/src/xen_internal.c
@@ -29,6 +29,7 @@
 #include "xs_internal.h"
 #include "stats_linux.h"
 #include "xend_internal.h"
+#include "util.h"
 
 /* required for dom0_getdomaininfo_t */
 #include <xen/dom0_ops.h>
@@ -2345,7 +2346,7 @@ xenHypervisorMakeCapabilitiesInternal(virConnectPtr conn,
                 }
 
                 /* Too many arch flavours - highly unlikely ! */
-                if (i >= sizeof(guest_archs)/sizeof(guest_archs[0]))
+                if (i >= ARRAY_CARDINALITY(guest_archs))
                     continue;
                 /* Didn't find a match, so create a new one */
                 if (i == nr_guest_archs)

diff --git a/src/xend_internal.c b/src/xend_internal.c
index 21f1f1ab4d8e4b226f16f72a27987c94f926f1c8..bad9de36db5f762876fa5f120522a4c0953b4d5f 100644 (file)
--- a/src/xend_internal.c
+++ b/src/xend_internal.c
@@ -2312,7 +2312,7 @@ xenDaemonParseSxpr(virConnectPtr conn,
     if (hvm) {
         const char *const fds[] = { "fda", "fdb" };
         int i;
-        for (i = 0 ; i < sizeof(fds)/sizeof(fds[0]) ; i++) {
+        for (i = 0 ; i < ARRAY_CARDINALITY(fds) ; i++) {
             tmp = sexpr_fmt_node(root, "domain/image/hvm/%s", fds[i]);
             if ((tmp != NULL) && (tmp[0] != 0)) {
                 virDomainDiskDefPtr disk;

diff --git a/tests/nodeinfotest.c b/tests/nodeinfotest.c
index 2e0274aa585cca52164d796bd70aa8b25216ea89..66f60d9e78e9313943292ba69ef38f9db4cda330 100644 (file)
--- a/tests/nodeinfotest.c
+++ b/tests/nodeinfotest.c
@@ -8,6 +8,7 @@
 #include "testutils.h"
 #include "internal.h"
 #include "nodeinfo.h"
+#include "util.h"
 
 static char *progname;
 static char *abs_srcdir;
@@ -95,7 +96,7 @@ mymain(int argc, char **argv)
 
     virInitialize();
 
-    for (i = 0 ; i < (sizeof(nodeData)/sizeof(nodeData[0])) ; i++)
+    for (i = 0 ; i < ARRAY_CARDINALITY(nodeData); i++)
       if (virtTestRun(nodeData[i], 1, linuxTestNodeInfo, nodeData[i]) != 0)
         ret = -1;
 #endif

diff --git a/tests/qparamtest.c b/tests/qparamtest.c
index b85a29f691f1f4229711e716e29dc481da65065b..f8f2d29d356f11da76550b506f80786933e8c7b9 100644 (file)
--- a/tests/qparamtest.c
+++ b/tests/qparamtest.c
@@ -193,7 +193,7 @@ mymain(int argc ATTRIBUTE_UNUSED,
         struct qparamParseData info = {                                 \
             queryIn,                                                    \
             queryOut ? queryOut : queryIn,                              \
-            sizeof(params)/sizeof(params[0]),                           \
+            ARRAY_CARDINALITY(params),                                  \
             params };                                                   \
         if (virtTestRun("Parse " queryIn,                               \
                         1, qparamParseTest, &info) < 0)                 \