The path was freed before printing the error message, resulting in:
error : virSysinfoRead:773 : internal error Failed to execute command
(null)
But virCommandRun already gives a better error message.
* src/util/sysinfo.c (virSysinfoRead): Avoid overwriting error.
cmd = virCommandNewArgList(path, "-q", "-t", "0,1,4,17", NULL);
VIR_FREE(path);
virCommandSetOutputBuffer(cmd, &outbuf);
- if (virCommandRun(cmd, NULL) < 0) {
- virReportError(VIR_ERR_INTERNAL_ERROR,
- _("Failed to execute command %s"),
- path);
+ if (virCommandRun(cmd, NULL) < 0)
goto cleanup;
- }
if (VIR_ALLOC(ret) < 0)
goto no_memory;