]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: snapshot: Unify 'cleanup' and 'error' in qemuDomainSnapshotCreateDiskActive
authorPeter Krempa <pkrempa@redhat.com>
Wed, 5 Jun 2019 13:33:53 +0000 (15:33 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 10 Jun 2019 12:01:09 +0000 (14:01 +0200)
All cases taking the 'cleanup' path can take the original 'error' path.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_driver.c

index c1f0ad02075be75f181c8dc228643cdfa4139fc3..0b4cc49f9c114f60f8c6d92d69a403d9b7cee300 100644 (file)
@@ -15267,7 +15267,7 @@ qemuDomainSnapshotCreateDiskActive(virQEMUDriverPtr driver,
         if (qemuDomainSnapshotCreateSingleDiskActive(driver, vm,
                                                      &diskdata[i],
                                                      actions, reuse) < 0)
-            goto error;
+            goto cleanup;
 
         do_transaction = true;
     }
@@ -15291,12 +15291,12 @@ qemuDomainSnapshotCreateDiskActive(virQEMUDriverPtr driver,
         }
 
         if (rc < 0)
-            goto error;
+            goto cleanup;
     }
 
     ret = 0;
 
error:
cleanup:
     if (ret < 0) {
         virErrorPreserveLast(&orig_err);
     } else {
@@ -15320,7 +15320,6 @@ qemuDomainSnapshotCreateDiskActive(virQEMUDriverPtr driver,
                                            vm->newDef) < 0))
         ret = -1;
 
- cleanup:
     qemuDomainSnapshotDiskDataCleanup(diskdata, ndiskdata, driver, vm);
     virErrorRestore(&orig_err);