]> xenbits.xensource.com Git - libvirt.git/commitdiff
virsh-snapshot: Simplify cleanup path in cmdSnapshotEdit
authorPeter Krempa <pkrempa@redhat.com>
Thu, 7 Mar 2013 10:18:18 +0000 (11:18 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 21 Mar 2013 11:32:04 +0000 (12:32 +0100)
tools/virsh-snapshot.c

index 4edb8fd60d2d8e293e38fe02f570bcfd9655c1a1..44a1e03faaafd38304e9080fae261de9e6eec0a0 100644 (file)
@@ -567,9 +567,8 @@ cmdSnapshotEdit(vshControl *ctl, const vshCmd *cmd)
         vshCommandOptBool(cmd, "snapshotname"))
         define_flags |= VIR_DOMAIN_SNAPSHOT_CREATE_CURRENT;
 
-    dom = vshCommandOptDomain(ctl, cmd, NULL);
-    if (dom == NULL)
-        goto cleanup;
+    if (!(dom = vshCommandOptDomain(ctl, cmd, NULL)))
+        return false;
 
     if (vshLookupSnapshot(ctl, cmd, "snapshotname", false, dom,
                           &snapshot, &name) < 0)
@@ -628,8 +627,7 @@ cleanup:
         virDomainSnapshotFree(edited);
     if (snapshot)
         virDomainSnapshotFree(snapshot);
-    if (dom)
-        virDomainFree(dom);
+    virDomainFree(dom);
     return ret;
 }