]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
qemu: unlock qemu driver before return from domain save
authorHu Tao <hutao@cn.fujitsu.com>
Wed, 30 Mar 2011 02:34:16 +0000 (10:34 +0800)
committerDaniel Veillard <veillard@redhat.com>
Wed, 30 Mar 2011 02:34:16 +0000 (10:34 +0800)
qemuDriverUnlock() wasn't called on 2 exit paths
* src/qemu/qemu_driver.c: fix qemudDomainSave() to always unlock
  the driver before exiting on error

src/qemu/qemu_driver.c

index 8505669a15e8c5a90465d51e886e9c3dbf9382e7..dd12dc8550a4b27dc682308b874a9d048524dcb4 100644 (file)
@@ -2068,13 +2068,13 @@ static int qemudDomainSave(virDomainPtr dom, const char *path)
             qemuReportError(VIR_ERR_OPERATION_FAILED,
                             "%s", _("Invalid save image format specified "
                                     "in configuration file"));
-            return -1;
+            goto cleanup;
         }
         if (!qemudCompressProgramAvailable(compressed)) {
             qemuReportError(VIR_ERR_OPERATION_FAILED,
                             "%s", _("Compression program for image format "
                                     "in configuration file isn't available"));
-            return -1;
+            goto cleanup;
         }
     }