]> xenbits.xensource.com Git - people/dariof/xen.git/commitdiff
xen: Fix XSM build after dropping XEN_DOMCTL_getmemlist
authorAndrew Cooper <andrew.cooper3@citrix.com>
Fri, 26 Jan 2018 19:33:40 +0000 (19:33 +0000)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Mon, 29 Jan 2018 15:39:24 +0000 (15:39 +0000)
c/s 94450e36bfbb removed XEN_DOMCTL_getmemlist entirely, but missed adjusting
the XSM side of things.  As far as I can tell, 'pagelist' wasn't even offered
to dom0 in default policy.

Also, drop the stale struct xen_domctl_getmemlist which was missed from the
same changeset.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
xen/include/public/domctl.h
xen/xsm/flask/hooks.c
xen/xsm/flask/policy/access_vectors

index fb8b9379ffcc41f872c87e654d7a7b2d97e58c09..ec7a860afcf58a38ec9806d0a35dbf069ea38e80 100644 (file)
@@ -122,19 +122,6 @@ typedef struct xen_domctl_getdomaininfo xen_domctl_getdomaininfo_t;
 DEFINE_XEN_GUEST_HANDLE(xen_domctl_getdomaininfo_t);
 
 
-/* XEN_DOMCTL_getmemlist */
-struct xen_domctl_getmemlist {
-    /* IN variables. */
-    /* Max entries to write to output buffer. */
-    uint64_aligned_t max_pfns;
-    /* Start index in guest's page list. */
-    uint64_aligned_t start_pfn;
-    XEN_GUEST_HANDLE_64(uint64) buffer;
-    /* OUT variables. */
-    uint64_aligned_t num_pfns;
-};
-
-
 /* XEN_DOMCTL_getpageframeinfo */
 
 #define XEN_DOMCTL_PFINFO_LTAB_SHIFT 28
@@ -1194,7 +1181,6 @@ struct xen_domctl {
     union {
         struct xen_domctl_createdomain      createdomain;
         struct xen_domctl_getdomaininfo     getdomaininfo;
-        struct xen_domctl_getmemlist        getmemlist;
         struct xen_domctl_getpageframeinfo3 getpageframeinfo3;
         struct xen_domctl_nodeaffinity      nodeaffinity;
         struct xen_domctl_vcpuaffinity      vcpuaffinity;
index 3533259f9f9de3c10abcf16eeab1246f39c294e0..1802d8dfe6d1e3323036e3ff7d145acbfc5e65ef 100644 (file)
@@ -669,9 +669,6 @@ static int flask_domctl(struct domain *d, int cmd)
     case XEN_DOMCTL_getpageframeinfo3:
         return current_has_perm(d, SECCLASS_MMU, MMU__PAGEINFO);
 
-    case XEN_DOMCTL_getmemlist:
-        return current_has_perm(d, SECCLASS_MMU, MMU__PAGELIST);
-
     case XEN_DOMCTL_hypercall_init:
         return current_has_perm(d, SECCLASS_DOMAIN, DOMAIN__HYPERCALL);
 
index e74d98d736162358c03e70999a0b1045e72bdb79..89b99966bbf0e552357989604c79c8be0debf1bb 100644 (file)
@@ -357,8 +357,6 @@ class mmu
     map_write
 # XEN_DOMCTL_getpageframeinfo3
     pageinfo
-# XEN_DOMCTL_getmemlist
-    pagelist
 # XENMEM_{increase,decrease}_reservation, XENMEM_populate_physmap
     adjust
 # XENMEM_{current,maximum}_reservation, XENMEM_maximum_gpfn